Fix suspicious code fragments #112384
Merged
Fix suspicious code fragments #112384
+13
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributes to dotnet#112344
dotnet-issue-labeler
bot
added
the
needs-area-label
jkotas
commented
Feb 11, 2025
| @@ -66,7 +66,7 @@ public static void SetAsIConvertible(this ref ComVariant variant, IConvertible v | |||
| case TypeCode.Int32: variant = ComVariant.Create(value.ToInt32(ci)); break; | |||
| case TypeCode.UInt32: variant = ComVariant.Create(value.ToUInt32(ci)); break; | |||
| case TypeCode.Int64: variant = ComVariant.Create(value.ToInt64(ci)); break; | |||
| case TypeCode.UInt64: variant = ComVariant.Create(value.ToInt64(ci)); break; | |||
There was a problem hiding this comment.
This is a long-standing bug from at least .NET 6, likely .NET Framework (as it's in the DLR version this code was initially ported from as well):
I think we can fix this going forward, but as this does change the variant type I'd be concerned of breaking consumers if we were to backport this fix.
There was a problem hiding this comment.
Right, I do not think this is something that we want to backport.
jkotas
commented
Feb 11, 2025
| @@ -734,7 +734,7 @@ private static bool MatchesTheFilter(MethodBuilderImpl method, BindingFlags meth | |||
|
|
|||
| if (argType.IsArray != paramType.IsArray || | |||
| argType.IsByRef != paramType.IsByRef || | |||
| argType.IsPointer != argType.IsPointer) | |||
There was a problem hiding this comment.
This is a real corner case bug, but I do not think it is worth it to add a test case that hits it.
jkotas
commented
Feb 11, 2025
| @@ -161,9 +161,6 @@ static public StackValue CreateFromType(TypeDesc type) | |||
|
|
|||
| public override bool Equals(object obj) | |||
| { | |||
| if (Object.ReferenceEquals(this, obj)) | |||
jkotas
commented
Feb 11, 2025
| @@ -577,9 +577,6 @@ protected override void OutputMemberScopeModifier(MemberAttributes attributes) | |||
| case MemberAttributes.Override: | |||
| Output.Write("Overrides "); | |||
| break; | |||
| case MemberAttributes.Private: | |||
There was a problem hiding this comment.
Unreachable code. Legacy components - keeping the existing behavior.
jkotas
commented
Feb 11, 2025
| @@ -3023,22 +3023,19 @@ private void ImplReadData(BinXmlToken tokenType) | |||
|
|
|||
| private void ImplReadElement() | |||
| { | |||
| if (3 != _docState || 9 != _docState) | |||
jkotas
added
area-System.Runtime.InteropServices
and removed
needs-area-label
|
Tagging subscribers to this area: @dotnet/interop-contrib |
AaronRobinsonMSFT
approved these changes
Feb 11, 2025
filipnavara
approved these changes
Feb 11, 2025
This was referenced Feb 11, 2025
Open
Open
jkotas
commented
Feb 12, 2025
src/libraries/System.Reflection.Emit/src/System/Reflection/Emit/TypeBuilderImpl.cs
Outdated
Show resolved
Hide resolved
…t/TypeBuilderImpl.cs
This was referenced Feb 12, 2025
|
/ba-g unrelated timeouts due to overloaded queues |
grendello
added a commit
to grendello/runtime
that referenced
this pull request
Feb 12, 2025
* main: [Android] Run CoreCLR functional tests on Android (dotnet#112283) [LoongArch64] Fix some assertion failures for Debug ILC building Debug NativeAOT testcases. (dotnet#112229) Fix suspicious code fragments (dotnet#112384) `__ComObject` doesn't support dynamic interface map (dotnet#112375) Native DLLs: only load imported DLLs from System32 (dotnet#112359) [main] Update dependencies from dotnet/roslyn (dotnet#112314) Update SVE instructions that writes to GC regs (dotnet#112389) Bring up android+coreclr windows build. (dotnet#112256) Never use heap for return buffers (dotnet#112060) Wait to complete the test before releasing the agile reference. (dotnet#112387) Prevent returning disposed HTTP/1.1 connections to the pool (dotnet#112383) Fingerprint dotnet.js if writing import map to html is enabled (dotnet#112407) Remove duplicate definition of CORECLR_HOSTING_API_LINKAGE (dotnet#112096) Update the exception message to reflect current behavior. (dotnet#112355) Use enum for frametype not v table (dotnet#112166) Enable AltJits build for LoongArch64 and RiscV64 (dotnet#110282) Guard members of MonoType union & fix related bugs (dotnet#111645) Add optional hooks for debugging OpenSSL memory allocations (dotnet#111539) JIT: Optimize struct parameter register accesses in the backend (dotnet#110819) NativeAOT: Cover more opcodes in type preinitializer (dotnet#112073)
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #112344