-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[wasm] build paltests #112404
Open
radekdoulik
wants to merge
59
commits into
dotnet:main
Choose a base branch
from
radekdoulik:wasm-build
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[wasm] build paltests #112404
+491
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disable few parts, some might need closer look later.
And also skip creating pipe to communicate with it
…t it was so you can pull the test statuses out of a log file
To avoid error messages at the end of each run
Also write missing tests
Also fix disabled tests count
Add few more notes to failing memory related tests
Emscripten's mmap doesn't support that and because we don't have virtual memory in wasm, it doesn't make sense to call it there
Also re-enable debug test, which works and disable few MT tests
This was referenced Feb 13, 2025
jkotas
reviewed
Feb 14, 2025
vitek-karas
reviewed
Feb 14, 2025
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
This was referenced Feb 14, 2025
Open
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.