Ensure Loader tests create deps file #112500
Conversation
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (2)
- src/libraries/System.Runtime.Loader/tests/DefaultContext/System.Runtime.Loader.DefaultContext.Tests.csproj: Language not supported
- src/libraries/System.Runtime.Loader/tests/System.Runtime.Loader.Tests.csproj: Language not supported
dotnet-issue-labeler
bot
added
the
needs-area-label
ericstj
added
area-AssemblyLoader-coreclr
and removed
needs-area-label
| @@ -2,8 +2,6 @@ | |||
| <PropertyGroup> | |||
| <TargetFramework>$(NetCoreAppCurrent)</TargetFramework> | |||
| <TestRuntime>true</TestRuntime> | |||
| <!-- LoadInDefaultContext test relies on no deps.json --> | |||
There was a problem hiding this comment.
For reference, this was introduced in dotnet/corefx#39279 cc @ViktorHofer
There was a problem hiding this comment.
Seems that also modified Reflection tests which was fixed by @steveharter in ac8ed29
I bet there was a reason for it at the time, but most likely we've changed the test runner since then.
I did a search for any other tests breaking this and didn't find any: https://github.com/search?q=repo%3Adotnet%2Fruntime+GenerateDependencyFile+path%3A*tests*csproj&type=code
|
Tests passed for me locally. We'll see what happens in validation. Looks like things are pretty 🔥 🚒 🟥 right now. |
|
/ba-g known win2025 infra issue |
|
Thank you! |
Fixes #112471