Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Mark Value/HasValue/GetValueOrDefault members of Nullable<T> as readonly #1727

Merged
merged 1 commit into from
Jan 15, 2020
Merged

Mark Value/HasValue/GetValueOrDefault members of Nullable<T> as readonly #1727

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/libraries/System.Private.CoreLib/src/System/Nullable.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,13 +26,13 @@ public Nullable(T value)
hasValue = true;
}

public bool HasValue
public readonly bool HasValue
{
[NonVersionable]
get => hasValue;
}

public T Value
public readonly T Value
{
get
{
Expand All @@ -45,10 +45,10 @@ public T Value
}

[NonVersionable]
public T GetValueOrDefault() => value;
public readonly T GetValueOrDefault() => value;

[NonVersionable]
public T GetValueOrDefault(T defaultValue) =>
public readonly T GetValueOrDefault(T defaultValue) =>
hasValue ? value : defaultValue;

public override bool Equals(object? other)
Expand Down
8 changes: 4 additions & 4 deletions src/libraries/System.Runtime/ref/System.Runtime.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1911,12 +1911,12 @@ public partial struct Nullable<T> where T : struct
private T value;
private int _dummyPrimitive;
public Nullable(T value) { throw null; }
public bool HasValue { get { throw null; } }
public T Value { get { throw null; } }
public readonly bool HasValue { get { throw null; } }
public readonly T Value { get { throw null; } }
public override bool Equals(object? other) { throw null; }
public override int GetHashCode() { throw null; }
public T GetValueOrDefault() { throw null; }
public T GetValueOrDefault(T defaultValue) { throw null; }
public readonly T GetValueOrDefault() { throw null; }
public readonly T GetValueOrDefault(T defaultValue) { throw null; }
public static explicit operator T (T? value) { throw null; }
public static implicit operator T? (T value) { throw null; }
public override string? ToString() { throw null; }
Expand Down