-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
enable zip unicode tests on OSX #1728
Conversation
All configurations leg was just fixed in: #1729 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the change, @wfurt. I clicked on Re-Run for the failed CI runs, but maybe a rebase is required?
/azp list |
/azp run runtime-libraries |
No pipelines are associated with this pull request. |
@wfurt runtime-installer pipeline is deprecated, now everything is part of the "runtime" pipeline. We're in the process of updating docs... if you want to remove the red badges, you can amend your commit (to change the hash) and push, or just ignore the failures in runtime-libraries if "runtime" is green, we test the same things now in "runtime". The failure you're seeing on Installer Build and Test Windows_NT_x86 Release is a known issue and you can ignore, so basically this PR is good to merge. |
I really wanted to run ' (Libraries Build OSX x64 Debug)' Since it was canceled I could not use restart option. |
Right, but the one that was cancelled was the one under the "runtime-libraries" pipeline. If you look at the "runtime" pipeline it also has a step to Build OSX x64 Debug and run tests: That's what I meant with now these steps are part of the "runtime" pipeline as "runtime-libraries" no longer exist. The reason why it is showed, is because GH stores the badge information in relation to the HEAD commit hash, since you only closed/re-open the PR and the pipelines changed while your PR was open, it will see that the hash existed and will not remove badges for builds that no longer exist. |
I did test ruin on my OSX and it seems to work fine.
fixes #1551