Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Have SIMDIntrinsicUpperSave and SIMDIntrinsicUpperRestore set a baseType if one can't otherwise be determined #35899

Merged
merged 1 commit into from
May 7, 2020
Merged

Have SIMDIntrinsicUpperSave and SIMDIntrinsicUpperRestore set a baseType if one can't otherwise be determined #35899

merged 1 commit into from
May 7, 2020

Conversation

tannergooding
Copy link
Member

This resolves #35876

@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label May 6, 2020
@tannergooding tannergooding mentioned this pull request May 6, 2020
Closed
@tannergooding
Copy link
Member Author

This also fixes #35620, but I think it should probably be kept open so that a better fix can be put in place. Ideally we would always track the relevant class handle so that we don't have to lie about the type.

I mentioned a possible alternative here, but I believe they are all more involved changes.

@BruceForstall BruceForstall requested a review from CarolEidt May 6, 2020 19:10
@tannergooding
Copy link
Member Author

Test failure is the other issue being fixed by #35904

@tannergooding
Copy link
Member Author

jitstress failure on OSX is also a separate issue: #35798 (comment)

CarolEidt
CarolEidt approved these changes May 6, 2020
View reviewed changes
Copy link
Contributor

@CarolEidt CarolEidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks!
It's weird, but I actually have a recollection of fixing this before, but I'm obviously mistaken!

@tannergooding tannergooding merged commit ddade10 into dotnet:master May 7, 2020
@BruceForstall BruceForstall mentioned this pull request May 18, 2020
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Dec 9, 2020
@tannergooding tannergooding deleted the fix-35876 branch November 11, 2022 15:30
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@CarolEidt CarolEidt CarolEidt approved these changes

Assignees
No one assigned
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test failure: Assertion failed '!"SIMD intrinsic with unsupported base type."'
3 participants
@tannergooding @CarolEidt @Dotnet-GitSync-Bot