Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Rename MinimumOSPlatformAttribute and RemovedInOSPlatformAttribute #40371

Merged
merged 4 commits into from
Aug 5, 2020
Merged

Rename MinimumOSPlatformAttribute and RemovedInOSPlatformAttribute #40371

merged 4 commits into from
Aug 5, 2020

Conversation

adamsitnik
Copy link
Member

fixes #40360

cc @terrajobst

@adamsitnik
rename attributes:
9de840b 
* MinimumOSPlatformAttribute -> SupportedOSPlatformAttribute
* RemovedInOSPlatformAttribute -> UnsupportedOSPlatformAttribute
@adamsitnik
update src snd ref files
a9ae93a
@adamsitnik
update .targets file
c920ffa
@Dotnet-GitSync-Bot
Copy link
Collaborator

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@adamsitnik
Copy link
Member Author

@krwq @eiriktsarpalis any chances I could get an approval from you during European working hours? this PR blocks me from fixing #40095 and I would prefer to send two separate PRs

This was referenced Aug 5, 2020
Merged
Closed
krwq
krwq approved these changes Aug 5, 2020
View reviewed changes
Copy link
Member

@krwq krwq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, please fix build errors

@adamsitnik
Copy link
Member Author

the build failures seem unrelated, merging

@adamsitnik adamsitnik merged commit 06963ea into dotnet:master Aug 5, 2020
@adamsitnik adamsitnik deleted the platformAttributes branch August 5, 2020 11:47
jeffhandley
jeffhandley reviewed Aug 5, 2020
View reviewed changes
Copy link
Member

@jeffhandley jeffhandley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@adamsitnik adamsitnik mentioned this pull request Aug 7, 2020
Closed
Jacksondr5 pushed a commit to Jacksondr5/runtime that referenced this pull request Aug 10, 2020
@adamsitnik @Jacksondr5
Rename MinimumOSPlatformAttribute and RemovedInOSPlatformAttribute (d…
92ee4cd 
…otnet#40371)

* rename attributes:

* MinimumOSPlatformAttribute -> SupportedOSPlatformAttribute
* RemovedInOSPlatformAttribute -> UnsupportedOSPlatformAttribute

* update src and ref files

* update .targets file

* update comment ;)
@eerhardt eerhardt mentioned this pull request Aug 12, 2020
Merged
@karelz karelz modified the milestones: 6.0.0, 5.0.0 Aug 18, 2020
@adamsitnik adamsitnik mentioned this pull request Sep 9, 2020
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Dec 7, 2020
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@jeffhandley jeffhandley jeffhandley left review comments

@krwq krwq krwq approved these changes

@buyaa-n buyaa-n Awaiting requested review from buyaa-n

Assignees
No one assigned
Labels
area-System.Runtime.InteropServices
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.

Rename MinimumOSPlatformAttribute and RemovedInOSPlatformAttribute
5 participants
@adamsitnik @Dotnet-GitSync-Bot @krwq @jeffhandley @karelz