Add Put/Post methods to HttpClientJsonExtensions that take type metadata #51609
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layomia
requested review from
eiriktsarpalis,
steveharter,
eerhardt,
ManickaP,
joperezr and
jozkee
|
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
ghost
added
the
|
Tagging subscribers to this area: @eiriktsarpalis, @layomia Issue DetailsContributes to #51544.
|
layomia
commented
Apr 21, 2021
layomia
commented
Apr 21, 2021
src/libraries/System.Net.Http.Json/src/System/Net/Http/Json/JsonContentOfT.cs
Outdated
Show resolved
Hide resolved
layomia
changed the title
steveharter
reviewed
Apr 21, 2021
src/libraries/System.Net.Http.Json/src/System/Net/Http/Json/Helper.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Net.Http.Json/src/System/Net/Http/Json/Helper.cs
Outdated
Show resolved
Hide resolved
steveharter
reviewed
Apr 21, 2021
| else | ||
| { | ||
| #if NETCOREAPP | ||
| // Have to use Utf8JsonWriter because JsonSerializer doesn't support sync serialization into stream directly. |
There was a problem hiding this comment.
Note sync serialization will be added soon via #1574
steveharter
approved these changes
Apr 21, 2021
|
Hello @layomia! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit
This pull request was closed.
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #51544.