Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Update EnumerateLines docs #55367

Merged
merged 2 commits into from
Jul 22, 2021
Merged

Update EnumerateLines docs #55367

merged 2 commits into from
Jul 22, 2021

Conversation

GrabYourPitchforks
Copy link
Member

Updates devdoc for MemoryExtensions.EnumerateLines to clarify that protocol parsers should not utilize this API. The exact reasoning for this is stated more explicitly in the string.ReplaceLineEndings devdoc, but I didn't want to copy and paste a huge block of text here.

This is a doc-only change; no runtime code is changed.

@GrabYourPitchforks GrabYourPitchforks added documentation Documentation bug or enhancement, does not impact product or test code area-System.Memory labels Jul 8, 2021
@GrabYourPitchforks GrabYourPitchforks added this to the 6.0.0 milestone Jul 8, 2021
@ghost
Copy link

ghost commented Jul 8, 2021

Tagging subscribers to this area: @GrabYourPitchforks, @dotnet/area-system-memory
See info in area-owners.md if you want to be subscribed.

Issue Details

Updates devdoc for MemoryExtensions.EnumerateLines to clarify that protocol parsers should not utilize this API. The exact reasoning for this is stated more explicitly in the string.ReplaceLineEndings devdoc, but I didn't want to copy and paste a huge block of text here.

This is a doc-only change; no runtime code is changed.

Author: GrabYourPitchforks
Assignees: -
Labels:

area-System.Memory, documentation
Milestone: 6.0.0

@runfoapp runfoapp bot mentioned this pull request Jul 15, 2021
Closed
@ghost
Copy link

ghost commented Jul 22, 2021

Hello @jozkee!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@GrabYourPitchforks GrabYourPitchforks merged commit 541850a into dotnet:main Jul 22, 2021
@GrabYourPitchforks GrabYourPitchforks deleted the enumlines_com branch July 22, 2021 18:13
@GrabYourPitchforks
Copy link
Member Author

CI already passed (except for known issues), so I terminated the current CI run to free up resources.

@ghost ghost locked as resolved and limited conversation to collaborators Aug 21, 2021
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@stephentoub stephentoub stephentoub approved these changes

@jozkee jozkee jozkee approved these changes

@krwq krwq Awaiting requested review from krwq

@eiriktsarpalis eiriktsarpalis Awaiting requested review from eiriktsarpalis

Assignees
No one assigned
Labels
area-System.Memory documentation Documentation bug or enhancement, does not impact product or test code
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@GrabYourPitchforks @stephentoub @jozkee