Do not overwrite JsonException metadata #56903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @eiriktsarpalis, @layomia Issue DetailsAddresses a condition where making nested calls to Fixes #51537.
|
steveharter
reviewed
Aug 5, 2021
src/libraries/System.Text.Json/src/System/Text/Json/ThrowHelper.Serialization.cs
Show resolved
Hide resolved
steveharter
approved these changes
Aug 5, 2021
ghost
locked as resolved and limited conversation to collaborators
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses a condition where making nested calls to
JsonSerializercan result inJsonExceptionmetadata being overwritten by the outer serializer. The serializer will now recognize exception instances whereJsonSerializer.Pathis already populated and bubble them up without any modification (treating them like any other exception type).Fixes #51537.