-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Use XHarnessApkToTest to create helix work items for runtime tests when running on Android #57292
Use XHarnessApkToTest to create helix work items for runtime tests when running on Android #57292
Conversation
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the correct approach and what I hoped the solution might look like. Just beware that one thing will most likely break for Apple - you won't be able to read env variables, such as $HELIX_WORKITEM_UPLOAD_ROOT
, anymore thanks to the launchctl
workaround. So if the generated code calling XHarness uses these, it should switch over to variables defined by the Helix SDK (https://github.com/dotnet/arcade/tree/main/src/Microsoft.DotNet.Helix/Sdk/tools/xharness-runner#variables-defined-for-apple-scenarios)
@naricc is going to take a look at the suggested changes and take over this PR |
@premun Hey, I have been asked to pickup this work, but I didn't really get to speak to Fan before she went on vacation. I've progressed it with the obvious steps so far, but I am not sure where to go. I see that it is failing with HelixWorkItems is empty, but I assume the change removing the work items was done for a reason. Is this supposed to use another API that doesn't take HelixWorkItems? Is there a document I should be looking at for how CustomCommands is supposed to work? |
@naricc the docs for the XHarness part of the Helix SDK are here: https://github.com/dotnet/arcade/blob/main/src/Microsoft.DotNet.Helix/Sdk/tools/xharness-runner/Readme.md The goal is to define these If you see
I checked the binlog of your build quickly and I can see you are not defining them at all probably: |
ab54057
to
c3a6a08
Compare
Tagging subscribers to this area: @dotnet/runtime-infrastructure Issue Detailsnull
|
Currently, blocked by dotnet/arcade#7808 |
9723918
to
6b45575
Compare
This issue has been resolved. |
48a65ed
to
119723f
Compare
Co-authored-by: Přemek Vysoký <premek.vysoky@microsoft.com>
Co-authored-by: Přemek Vysoký <premek.vysoky@microsoft.com>
a076cfd
to
0115d42
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, though @premun is the expert here :)
No description provided.