-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Revert workarounds for mono/linker#2181 #57451
Conversation
Tagging subscribers to 'linkable-framework': @eerhardt, @vitek-karas, @LakshanF, @sbomer, @joperezr Issue DetailsTrying to revert both.
|
runtime (Libraries Test Run checked coreclr windows x86 Release) was #57452 |
@stephentoub @vargaz - I can't seem to repro the failure from #56316 (comment). Do you remember if there was something special needed? Or do I need to revert more changes? I honestly don't think that the fix made in dotnet/linker#2205 would fix problems with invalid finally (the fix is solely around @steveisok Could you please review the change in |
There was nothing special needed. However... in order to apply the ifdefs with minimal ceremony, I did invert one or two of the if/else blocks: |
Trying to revert both. The Http3RequestStream is definitely fixed by the linker changes. The ArrayPool ones probably not, but trying to get a repro.
b6876fb
to
d8b1b1b
Compare
@stephentoub could you please take another look - this should be ready. Thanks a lot! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This reverts the ArrayPool workaround for mono/linker@2181 as that issue was fully fixed and the fix is in the runtime repo now.