-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[mono] Replace -disable-fp-elim with -frame-pointer=all #58192
Conversation
`-disable-fp-elim` was removed in LLVM 8 in commit b7cef81fd36c85e52b115b9ed6d1fb92d63781d6. Also see https://reviews.llvm.org/D56351. The replacement option, `-frame-pointer`, is still present in LLVM 11. Fixes dotnet#58112.
@marek-safar - this needs to be backported to RC1 and 6.0 branches - if it comes up in any of your meetings |
/backport to release/6.0-rc1 |
Started backporting to release/6.0-rc1: https://github.com/dotnet/runtime/actions/runs/1171271793 |
I'm going to try to verify that this fixes #58112 by hand. The laptop I'm on is not especially fast and building a fresh If someone else already has a working copy of |
@imhameed please backport to 6.0 branch and send tactics approval request for RC1 |
Tested locally; works for me. I can build |
-disable-fp-elim
was removed in LLVM 8 in commit b7cef81fd36c85e52b115b9ed6d1fb92d63781d6.Also see https://reviews.llvm.org/D56351.
The replacement option,
-frame-pointer
, is still present in LLVM 11.Fixes #58112.