[release/7.0-rc2] Try re-enabling System.Transactions.Local tests on Arm64 #75703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
cc @roji |
|
@jkotas - I see a change in product code, so I think this should go through ask-mode: Can you please fill the template, add the |
|
@carlossanlop yeah, I'll be taking care of that, thanks... |
stephentoub
approved these changes
Sep 19, 2022
rbhanda
added
Servicing-approved
|
Test failure is an unrelated infra problem when attempting to retrieve a package. I reported it to First Responders in case it's something that needs investigation. |
carlossanlop
added a commit
that referenced
this pull request
Sep 26, 2022
* Fix querying L3 cache size on osx-x64 (#75870) Co-authored-by: Filip Navara <navara@emclient.com> * KeyChar should be preserved for Ctrl+Letter (#75861) Co-authored-by: Adam Sitnik <adam.sitnik@gmail.com> * Try re-enabling System.Transactions.Local tests on Arm64 (#75703) Co-authored-by: Jan Kotas <jkotas@microsoft.com> * Updating inbox source generators to Roslyn 4.4 and removing polyfill approach (#75717) (#75875) * Removed internalProperties group from proxy and tests. (#75906) Co-authored-by: Ilona Tomkowicz <itomkowicz@microsoft.com> * [release/7.0-rc2] Fixing SpanHelpers.LastIndexOfAnyValueType to no longer create out of bounds GC refs (#75885) * Fixing SpanHelpers.LastIndexOfAnyValueType to no longer create out of bounds GC refs * Apply suggestions from code review Co-authored-by: Adam Sitnik <adam.sitnik@gmail.com> * Adjusting the comment as per PR review feedback Co-authored-by: Tanner Gooding <tagoo@outlook.com> Co-authored-by: Adam Sitnik <adam.sitnik@gmail.com> * Bump intellisense package for RC2 to include latest comments for Numerics (#75938) Co-authored-by: carlossanlop <carlossanlop@users.noreply.github.com> * [release/7.0-rc2] [Mono] Restore old code to solve the recent SpanHelpers regressions (#75996) * bring back the old code... * bring back more old code * Use an ifdef around clr code instead of a separate file * Delete SpanHelpers.Clr.cs * Remove a remaining INumber<T> helper from mono Co-authored-by: Adam Sitnik <adam.sitnik@gmail.com> Co-authored-by: Jeff Handley <jeffhandley@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Filip Navara <navara@emclient.com> Co-authored-by: Adam Sitnik <adam.sitnik@gmail.com> Co-authored-by: Jan Kotas <jkotas@microsoft.com> Co-authored-by: Jose Perez Rodriguez <joperezr@microsoft.com> Co-authored-by: Ilona Tomkowicz <itomkowicz@microsoft.com> Co-authored-by: Tanner Gooding <tagoo@outlook.com> Co-authored-by: Carlos Sanchez <1175054+carlossanlop@users.noreply.github.com> Co-authored-by: carlossanlop <carlossanlop@users.noreply.github.com> Co-authored-by: Jeff Handley <jeffhandley@users.noreply.github.com>
ghost
locked as resolved and limited conversation to collaborators
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #75610 to release/7.0-rc2
/cc @jkotas
Customer Impact
This PR enables distributed transaction support on Windows on arm64.
Testing
Due to a previous mis-communication, it was believed that we're still seeing AccessViolationException even after some interop fixes (see #74226). However, we're no longer able to reproduce the AccessViolationException. All testing has been unskipped for arm64.
Risk
The change itself is very low risk, as it simply removes a check and a throw for arm64.