-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Fix CPU_COUNT check for FreeBSD 13.1+ #77867
Conversation
more info: With the two sched checks passing but CPU_COUNT failing it will try and make its own CPU_COUNT...and fail because FreeBSD already has a macro it uses for that. Thinking about it more, the other option would be to opt FreeBSD out of |
Switched to For those wondering: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you! |
HAVE_GNU_CPU_COUNT has always incorrectly failed for FreeBSD.
This has not been an issue until FreeBSD 13.1 with its addition of
sched_getaffinity
andsched_setaffinity
.