Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[mono] Reuse handles inside a loop in reflection_create_dynamic_metho… #79716

Merged
merged 1 commit into from
Dec 28, 2022

Conversation

vargaz
Copy link
Contributor

@vargaz vargaz commented Dec 15, 2022

…d ().

This fixes the 'reflection_create_dynamic_method USED x handles' warnings.

…d ().

This fixes the 'reflection_create_dynamic_method USED x handles' warnings.
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-VM-reflection-mono Reflection issues specific to MonoVM label Dec 15, 2022
@vargaz vargaz removed the request for review from thaystg December 15, 2022 20:02
@ghost ghost assigned vargaz Dec 15, 2022
@srxqds
Copy link
Contributor

srxqds commented Dec 15, 2022

@vargaz
Copy link
Contributor Author

vargaz commented Dec 16, 2022

Failures are unrelated.

@srxqds
Copy link
Contributor

srxqds commented Dec 26, 2022

can this backport to release/7.0?

@srxqds
Copy link
Contributor

srxqds commented Dec 27, 2022

hi, @vargaz will this pr also fix the performance problem, I have disccussed with @lateralusX at https://discord.com/channels/732297728826277939/732297965019988138/1052432861736730684

https://discord.com/channels/732297728826277939/732297965019988138/1052229317729472553

I have tested, this pr can't fix the performance of Linq.Expression

@vargaz vargaz merged commit fa7d049 into dotnet:main Dec 28, 2022
@vargaz vargaz deleted the sre-handles branch December 28, 2022 18:20
@ghost ghost locked as resolved and limited conversation to collaborators Jan 27, 2023
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
area-VM-reflection-mono Reflection issues specific to MonoVM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants