-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Declare CoreClrPgoDataArg variable in CI script #80324
Conversation
Tagging subscribers to this area: @hoyosjs Issue DetailsRuntime CI legs print this (non-fatal) error:
This is because runtime/eng/pipelines/coreclr/templates/build-job.yml Lines 191 to 196 in 5b0bf41
|
cc @EgorBo, @jakobbotsch This is basically silencing the warning which shows up on top of every macOS run. But since CoreClrPgoDataArg is never set in the pipelines, we may as well delete it. Thoughts? |
Actually, shouldn't this be an actual path? I think it's a NuGet path on some other runs (maybe musl?) |
@jkoritzinsky might remember the details when it was added (currently it is uninitialized and showing that error in logs from PR description). |
We calculate this path in an MSBuild project and set the variable from there when applying PGO instrumentation. This PR provides a default to remove the warning. I think it's a good thing to add. I've added a suggested comment to explain whats going on. I think I fixed this in my ASAN branch at some point, but I don't remember when. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with the suggested comment.
Co-authored-by: Jeremy Koritzinsky <jkoritzinsky@gmail.com>
Before:
After: