Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[Mono] Fix function pointer check #80855

Merged
merged 3 commits into from
Jan 23, 2023
Merged

[Mono] Fix function pointer check #80855

merged 3 commits into from
Jan 23, 2023

Conversation

fanyang-mono
Copy link
Member

@fanyang-mono fanyang-mono commented Jan 19, 2023 •
edited
Loading

Fix #80095

This PR fixed the function pointer checks for both interpreter and JIT. I also added runtime tests to lock down this behavior.

This fix needs to be backported to .NET7 when it gets approved.

@ghost ghost assigned fanyang-mono Jan 19, 2023
@MattGal
Copy link
Member

MattGal commented Jan 19, 2023

/azp run

@azure-pipelines
Copy link

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

@MattGal MattGal closed this Jan 19, 2023
@MattGal MattGal reopened this Jan 19, 2023
lambdageek
lambdageek approved these changes Jan 19, 2023
View reviewed changes
Copy link
Member

@lambdageek lambdageek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@runfoapp runfoapp bot mentioned this pull request Jan 19, 2023
Closed
@fanyang-mono
Copy link
Member Author

fanyang-mono commented Jan 20, 2023 •
edited
Loading

Similar crash seen on Build Libraries Test Run release mono linux arm64 Debug showed up on rolling build as well. Not related to this PR.

@fanyang-mono
Copy link
Member Author

Verified that newly added test ran on CI. Inspected CI lane Build osx-x64 Release AllSubsets_Mono_Interpreter_RuntimeTests monointerpreter. For work item Loader.classloader, where new test was added to, in this PR, there were 79 tests being run. (Loader.classloader.XUnitWrapper Total: 79, Errors: 0, Failed: 0, Skipped: 0, Time: 8.450s). For another currently open PR, there were 78 tests being run. (Loader.classloader.XUnitWrapper Total: 78, Errors: 0, Failed: 0, Skipped: 0, Time: 8.849s)

@fanyang-mono
Copy link
Member Author

/backport to release/7.0

@github-actions
Copy link
Contributor

Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/3969498723

@github-actions github-actions bot mentioned this pull request Jan 20, 2023
Merged
@fanyang-mono fanyang-mono merged commit d6c2b43 into dotnet:main Jan 23, 2023
mdh1418 pushed a commit to mdh1418/runtime that referenced this pull request Jan 24, 2023
@fanyang-mono @mdh1418
[Mono] Fix function pointer check (dotnet#80855)
9e09943 
* Fix function pointer check

* Make is_monomorphic_array return false when the element is function pointer

* Move test to a better location
@trylek trylek mentioned this pull request Jan 24, 2023
Closed
trylek added a commit that referenced this pull request Feb 2, 2023
@trylek
Backport of PR #81122 to .NET 7.0, revert change to issues.targets
565cd48 
Based on tactical discussion with Fan and Sam I have backported
the PR #81122 including the removal of the issues.targets entry
for function pointer tests as an extra commit on top of
the backport of Fan's PR #80855.

Thanks

Tomas
carlossanlop pushed a commit that referenced this pull request Feb 8, 2023
@github-actions @fanyang-mono @trylek
[release/7.0] [Mono] Fix function pointer check (#80927)
8502110 
* Fix function pointer check

* Make is_monomorphic_array return false when the element is function pointer

* Move test to a better location

* Disable function pointer test for crossgen due to an existing issue

* Backport of PR #81122 to .NET 7.0, revert change to issues.targets

Based on tactical discussion with Fan and Sam I have backported
the PR #81122 including the removal of the issues.targets entry
for function pointer tests as an extra commit on top of
the backport of Fan's PR #80855.

Thanks

Tomas

---------

Co-authored-by: Fan Yang <yangfan@microsoft.com>
Co-authored-by: Fan Yang <52458914+fanyang-mono@users.noreply.github.com>
Co-authored-by: Tomas <trylek@microsoft.com>
@ghost ghost locked as resolved and limited conversation to collaborators Feb 23, 2023
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@lambdageek lambdageek lambdageek approved these changes

@vargaz vargaz Awaiting requested review from vargaz

@thaystg thaystg Awaiting requested review from thaystg thaystg is a code owner

@SamMonoRT SamMonoRT Awaiting requested review from SamMonoRT

Assignees

@fanyang-mono fanyang-mono

Labels
area-Codegen-JIT-mono
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ArrayTypeMismatchException in nested arrays with function pointers (android)
3 participants
@fanyang-mono @MattGal @lambdageek