Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

disable NTLM tests on RedHat.7 #83559

Merged
merged 2 commits into from
Mar 17, 2023
Merged

disable NTLM tests on RedHat.7 #83559

merged 2 commits into from
Mar 17, 2023

Conversation

wfurt
Copy link
Member

@wfurt wfurt commented Mar 16, 2023

contributes to #83540
It seems like something got broken by OS update

@wfurt wfurt requested review from carlossanlop and a team March 16, 2023 23:09
@wfurt wfurt self-assigned this Mar 16, 2023
@ghost
Copy link

ghost commented Mar 16, 2023

Tagging subscribers to this area: @dotnet/ncl, @vcsjones
See info in area-owners.md if you want to be subscribed.

Issue Details

contributes to #83540
It seems like something got broken by OS update

Author: wfurt
Assignees: wfurt
Labels:

area-System.Net.Security

Milestone: -

Copy link
Member

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming the failure goes away in the CI, LGTM.

We will need a backport to 7.0 for sure.

I think we also need it in 6.0, but let me double check.

Thanks for the help!

@wfurt
Copy link
Member Author

wfurt commented Mar 17, 2023

I think it will need more fixes for System.Net.Security. Mail & Http seems ok now with this change.

@carlossanlop
Copy link
Member

I just confirmed. We also need this backported to 6.0 as well.

@wfurt
Copy link
Member Author

wfurt commented Mar 17, 2023

windows failure is unrelated

@wfurt wfurt merged commit 34c0472 into dotnet:main Mar 17, 2023
@wfurt wfurt deleted the ntlm branch March 17, 2023 05:41
@wfurt
Copy link
Member Author

wfurt commented Mar 17, 2023

/backport to release/7.0

@github-actions
Copy link
Contributor

Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/4449908354

@karelz karelz added this to the 8.0.0 milestone Mar 21, 2023
@karelz
Copy link
Member

karelz commented Mar 21, 2023

@wfurt should we mark the tracking issue as disabled-test, or is it by design disabling of the test for good?

@ghost ghost locked as resolved and limited conversation to collaborators Apr 20, 2023
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants