Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[main] Update dependencies from 10 repositories #83624

Merged
merged 40 commits into from
Apr 10, 2023
Merged

[main] Update dependencies from 10 repositories #83624

merged 40 commits into from
Apr 10, 2023

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Mar 17, 2023 •
edited
Loading

This pull request updates the following dependencies

From https://github.com/dotnet/llvm-project

  • Subscription: a7d541fc-4d59-4f09-2997-08d96284e872
  • Build: 20230329.1
  • Date Produced: March 29, 2023 10:35:55 PM UTC
  • Commit: e08f119fe5b5cace97abf56f69ac25717437c9d9
  • Branch: refs/heads/dotnet/main

From https://dev.azure.com/dnceng/internal/_git/dotnet-optimization

  • Subscription: d3a5b203-1393-4534-5b62-08d8d8feb47e
  • Build: 20230325.4
  • Date Produced: March 25, 2023 3:03:09 PM UTC
  • Commit: 103c1eaca9ad80cdd1746abfb97c7f3c9d0b0f3b
  • Branch: refs/heads/main

From https://github.com/dotnet/icu

  • Subscription: 4247a230-8931-4538-5b64-08d8d8feb47e
  • Build: 20230403.1
  • Date Produced: April 5, 2023 10:06:02 AM UTC
  • Commit: 389d19d09d3cf16ec0143dba065fcd704ab8e48c
  • Branch: refs/heads/dotnet/main

From https://github.com/dotnet/emsdk

  • Subscription: c22d5069-447c-4252-29fd-08d90a7bb4bc
  • Build: 20230405.3
  • Date Produced: April 5, 2023 8:05:13 PM UTC
  • Commit: 07ca08d31022f545d37fbc8d1254d3441645fce2
  • Branch: refs/heads/main

From https://github.com/dotnet/runtime

  • Subscription: 3db4b8c8-0fae-4f82-086c-08dad31ae87d
  • Build: 20230327.1
  • Date Produced: March 27, 2023 10:56:54 AM UTC
  • Commit: beb708f
  • Branch: refs/heads/main

From https://github.com/dotnet/msquic

  • Subscription: 2c02cca6-9dfc-41ac-a21d-08d94c99dc63
  • Build: 20230331.1
  • Date Produced: March 31, 2023 2:04:15 PM UTC
  • Commit: 1d12a72b61bc44c7f98c3c441c79262183777591
  • Branch: refs/heads/main

From https://github.com/dotnet/cecil

  • Subscription: bb5d2106-9fd3-425f-0abc-08daad65778c
  • Build: 20230328.1
  • Date Produced: March 28, 2023 4:09:36 PM UTC
  • Commit: 9a7551fa7ba8218affbc1148eabc4b5c9f4e1151
  • Branch: refs/heads/main

From https://github.com/dotnet/xharness

  • Subscription: be30ac4f-4b72-4287-1eb6-08d8d8fef0ea
  • Build: 20230328.2
  • Date Produced: March 28, 2023 4:16:20 PM UTC
  • Commit: 389c851b0dc1d2c50d03e4aad000b7802d0ebed6
  • Branch: refs/heads/main

From https://github.com/dotnet/runtime-assets

  • Subscription: 0c5a34f5-504e-413b-9376-08d8d8ff2d75
  • Build: 20230329.4
  • Date Produced: March 29, 2023 5:01:45 PM UTC
  • Commit: a18b8d48387a7980ba9e484ec7169c58731175e1
  • Branch: refs/heads/main

From https://github.com/dotnet/hotreload-utils

  • Subscription: bfe6dacf-8231-4ea1-e2fe-08d962847885
  • Build: 20230329.3
  • Date Produced: March 29, 2023 3:27:10 PM UTC
  • Commit: 9a231fca1b904f869577e7abac71aff263fd0559
  • Branch: refs/heads/main

@dotnet-maestro
Update dependencies from https://github.com/dotnet/llvm-project build…
b5189a3 
… 20230317.1

runtime.linux-arm64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.linux-arm64.Microsoft.NETCore.Runtime.ObjWriter , runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.ObjWriter , runtime.linux-musl-x64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.linux-musl-x64.Microsoft.NETCore.Runtime.ObjWriter , runtime.linux-x64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.linux-x64.Microsoft.NETCore.Runtime.ObjWriter , runtime.osx-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.osx-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.osx-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.osx-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.win-arm64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.win-arm64.Microsoft.NETCore.Runtime.ObjWriter , runtime.win-x64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.win-x64.Microsoft.NETCore.Runtime.ObjWriter
 From Version 14.0.0-alpha.1.23165.1 -> To Version 14.0.0-alpha.1.23167.1
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-codeflow for labeling automated codeflow label Mar 17, 2023
This was referenced Mar 18, 2023
Closed
Closed
@dotnet-maestro
Update dependencies from https://dev.azure.com/dnceng/internal/_git/d…
8dbff15 
…otnet-optimization build 20230317.4

optimization.linux-arm64.MIBC.Runtime , optimization.linux-x64.MIBC.Runtime , optimization.windows_nt-arm64.MIBC.Runtime , optimization.windows_nt-x64.MIBC.Runtime , optimization.windows_nt-x86.MIBC.Runtime , optimization.PGO.CoreCLR
 From Version 1.0.0-prerelease.23166.4 -> To Version 1.0.0-prerelease.23167.4
@dotnet-maestro dotnet-maestro bot changed the title [main] Update dependencies from dotnet/llvm-project [main] Update dependencies from dotnet/llvm-project dnceng/internal/dotnet-optimization Mar 18, 2023
@dotnet-maestro
Update dependencies from https://github.com/dotnet/icu build 20230317.1
b7e1cd6 
Microsoft.NETCore.Runtime.ICU.Transport
 From Version 8.0.0-preview.3.23163.3 -> To Version 8.0.0-preview.3.23167.1
@dotnet-maestro dotnet-maestro bot changed the title [main] Update dependencies from dotnet/llvm-project dnceng/internal/dotnet-optimization [main] Update dependencies from dotnet/llvm-project dnceng/internal/dotnet-optimization dotnet/icu Mar 18, 2023
@dotnet-maestro
Update dependencies from https://github.com/dotnet/emsdk build 202303…
abf18fc 
…17.2

Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100.Transport
 From Version 8.0.0-preview.3.23167.1 -> To Version 8.0.0-preview.3.23167.2
@dotnet-maestro dotnet-maestro bot changed the title [main] Update dependencies from dotnet/llvm-project dnceng/internal/dotnet-optimization dotnet/icu [main] Update dependencies from dotnet/llvm-project dnceng/internal/dotnet-optimization dotnet/icu dotnet/emsdk Mar 18, 2023
@dotnet-maestro dotnet-maestro bot changed the title [main] Update dependencies from dotnet/llvm-project dnceng/internal/dotnet-optimization dotnet/icu dotnet/emsdk [main] Update dependencies from dotnet/llvm-project dotnet/icu dotnet/emsdk dnceng/internal/dotnet-optimization Mar 19, 2023
@dotnet-maestro dotnet-maestro bot changed the title [main] Update dependencies from dotnet/llvm-project dotnet/icu dotnet/emsdk dnceng/internal/dotnet-optimization [main] Update dependencies from dotnet/llvm-project dotnet/emsdk dnceng/internal/dotnet-optimization dotnet/icu Mar 19, 2023
@dotnet-maestro dotnet-maestro bot changed the title [main] Update dependencies from dotnet/llvm-project dotnet/emsdk dnceng/internal/dotnet-optimization dotnet/icu [main] Update dependencies from dotnet/llvm-project dnceng/internal/dotnet-optimization dotnet/icu dotnet/emsdk Mar 19, 2023
@dotnet-maestro dotnet-maestro bot changed the title [main] Update dependencies from dotnet/llvm-project dnceng/internal/dotnet-optimization dotnet/icu dotnet/emsdk [main] Update dependencies from dotnet/llvm-project dotnet/icu dotnet/emsdk dnceng/internal/dotnet-optimization Mar 20, 2023
@dotnet-maestro dotnet-maestro bot changed the title [main] Update dependencies from dotnet/llvm-project dotnet/icu dotnet/emsdk dnceng/internal/dotnet-optimization [main] Update dependencies from dotnet/llvm-project dotnet/emsdk dnceng/internal/dotnet-optimization dotnet/icu Mar 20, 2023
@dotnet-maestro dotnet-maestro bot changed the title [main] Update dependencies from dotnet/llvm-project dotnet/emsdk dnceng/internal/dotnet-optimization dotnet/icu [main] Update dependencies from dotnet/llvm-project dnceng/internal/dotnet-optimization dotnet/icu dotnet/emsdk Mar 20, 2023
@dotnet-maestro
Update dependencies from https://github.com/dotnet/runtime build 2023…
1f8618a 
…0320.1

Microsoft.NET.ILLink.Tasks , Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.ILAsm , runtime.native.System.IO.Ports , System.Text.Json
 From Version 8.0.0-preview.3.23162.2 -> To Version 8.0.0-preview.3.23170.1
@dotnet-maestro dotnet-maestro bot changed the title [main] Update dependencies from dotnet/llvm-project dnceng/internal/dotnet-optimization dotnet/icu dotnet/emsdk [main] Update dependencies from dotnet/llvm-project dnceng/internal/dotnet-optimization dotnet/icu dotnet/emsdk dotnet/runtime Mar 20, 2023
This was referenced Mar 20, 2023
Closed
Closed
@dotnet-maestro
Update dependencies from https://github.com/dotnet/emsdk build 202303…
74a3e65 
…20.1

Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100.Transport
 From Version 8.0.0-preview.3.23167.1 -> To Version 8.0.0-preview.4.23170.1
@dotnet-maestro dotnet-maestro bot changed the title [main] Update dependencies from dotnet/llvm-project dnceng/internal/dotnet-optimization dotnet/icu dotnet/emsdk dotnet/runtime [main] Update dependencies from dotnet/llvm-project dnceng/internal/dotnet-optimization dotnet/icu dotnet/runtime dotnet/emsdk Mar 21, 2023
@dotnet-maestro
Update dependencies from https://github.com/dotnet/llvm-project build…
65c4c4a 
… 20230320.2

runtime.linux-arm64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.linux-arm64.Microsoft.NETCore.Runtime.ObjWriter , runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.ObjWriter , runtime.linux-musl-x64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.linux-musl-x64.Microsoft.NETCore.Runtime.ObjWriter , runtime.linux-x64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.linux-x64.Microsoft.NETCore.Runtime.ObjWriter , runtime.osx-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.osx-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.osx-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.osx-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.win-arm64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.win-arm64.Microsoft.NETCore.Runtime.ObjWriter , runtime.win-x64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.win-x64.Microsoft.NETCore.Runtime.ObjWriter
 From Version 14.0.0-alpha.1.23165.1 -> To Version 14.0.0-alpha.1.23170.2
@dotnet-maestro dotnet-maestro bot changed the title [main] Update dependencies from dotnet/llvm-project dnceng/internal/dotnet-optimization dotnet/icu dotnet/runtime dotnet/emsdk [main] Update dependencies from dnceng/internal/dotnet-optimization dotnet/icu dotnet/runtime dotnet/emsdk dotnet/llvm-project Mar 21, 2023
@build-analysis build-analysis bot mentioned this pull request Mar 21, 2023
Closed
dotnet-maestro bot added 2 commits March 21, 2023 05:21
@dotnet-maestro
Update dependencies from https://github.com/dotnet/llvm-project build…
3a1acb8 
… 20230320.3

runtime.linux-arm64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.linux-arm64.Microsoft.NETCore.Runtime.ObjWriter , runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.ObjWriter , runtime.linux-musl-x64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.linux-musl-x64.Microsoft.NETCore.Runtime.ObjWriter , runtime.linux-x64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.linux-x64.Microsoft.NETCore.Runtime.ObjWriter , runtime.osx-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.osx-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.osx-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.osx-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.win-arm64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.win-arm64.Microsoft.NETCore.Runtime.ObjWriter , runtime.win-x64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.win-x64.Microsoft.NETCore.Runtime.ObjWriter
 From Version 14.0.0-alpha.1.23165.1 -> To Version 14.0.0-alpha.1.23170.3
@dotnet-maestro
Update dependencies from https://dev.azure.com/dnceng/internal/_git/d…
89ed167 
…otnet-optimization build 20230320.4

optimization.linux-arm64.MIBC.Runtime , optimization.linux-x64.MIBC.Runtime , optimization.windows_nt-arm64.MIBC.Runtime , optimization.windows_nt-x64.MIBC.Runtime , optimization.windows_nt-x86.MIBC.Runtime , optimization.PGO.CoreCLR
 From Version 1.0.0-prerelease.23166.4 -> To Version 1.0.0-prerelease.23170.4
@dotnet-maestro dotnet-maestro bot changed the title [main] Update dependencies from dnceng/internal/dotnet-optimization dotnet/icu dotnet/runtime dotnet/emsdk dotnet/llvm-project [main] Update dependencies from dotnet/icu dotnet/runtime dotnet/emsdk dotnet/llvm-project dnceng/internal/dotnet-optimization Mar 21, 2023
@dotnet-maestro
Update dependencies from https://github.com/dotnet/icu build 20230320.4
4ffc33b 
Microsoft.NETCore.Runtime.ICU.Transport
 From Version 8.0.0-preview.3.23163.3 -> To Version 8.0.0-preview.4.23170.4
@dotnet-maestro dotnet-maestro bot changed the title [main] Update dependencies from dotnet/icu dotnet/runtime dotnet/emsdk dotnet/llvm-project dnceng/internal/dotnet-optimization [main] Update dependencies from dotnet/runtime dotnet/emsdk dotnet/llvm-project dnceng/internal/dotnet-optimization dotnet/icu Mar 21, 2023
@AndyAyersMS
Copy link
Member

My guess is that somehow we have old instrumentation data getting merged with new instrumentation data. With #80481 (Jan 13th) we changed instrumentation strategy from block to edge for all methods, so "old" would be something gathered with a jit built before this change.

@AndyAyersMS
Copy link
Member

@dotnet/jit-contrib looks like JIT doesn't like the new PGO data from the optimization repo update.

@AndyAyersMS ^. Wonder if having both edge and block counts is actually possible if we inline a method that had blocks?

That should not matter, since we only look at one method's schema at time, so the mixture of block and edge counts is happening within the schema for a single method.

dotnet-maestro bot added 2 commits April 6, 2023 15:23
@dotnet-maestro
Update dependencies from https://github.com/dotnet/emsdk build 202304…
4268ef0 
…05.3

Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100.Transport
 From Version 8.0.0-preview.4.23170.1 -> To Version 8.0.0-preview.4.23205.3
@dotnet-maestro
Update dependencies from https://github.com/dotnet/icu build 20230403.1
bbdd8e0 
Microsoft.NETCore.Runtime.ICU.Transport
 From Version 8.0.0-preview.3.23163.3 -> To Version 8.0.0-preview.4.23203.1
@build-analysis build-analysis bot mentioned this pull request Apr 6, 2023
Closed
@trylek
Copy link
Member

trylek commented Apr 6, 2023

So, several initial observations so far:

  • I'm able to repro the bug locally when I pull down the darc source branch and build clr -c Checked. It's probably natural that it doesn't repro in Release mode when C++ assertions are turned off but it's somewhat surprising for me that it also doesn't repro in debug mode.
  • I'm able to repro the bug even when I merge the darc source branch into runtime main and I revert Michal's change Speed up named type lookups in managed type system #84285 i.o.w. I don't think it's caused by the change.
  • Looking at the point of assertion failure in the debugger, I see that the problem happens when compiling the method System.RuntimeType.GetMethodBase(RuntimeMethodHandleInternal); in the method throwing the assertion failure I see that fgPgoSchemaCount = 102, fgPgoBlockCount = 38, fgPgoEdgeCount = 21 so we indeed seem to have both types of MIBC data available.
  • I am not super familiar with details of the MIBC data aggregation; at the first glance everything points to what @AndyAyersMS described - merging data containing block information with data containing edge information.

@lewing
Copy link
Member

lewing commented Apr 6, 2023 •
edited
Loading

the wasm build test failure is known (#84368 (comment)), I haven't seen the debugger failure before

@lewing
Copy link
Member

lewing commented Apr 6, 2023

wasm debugger test failure #84440

@AndyAyersMS
Copy link
Member

  • I am not super familiar with details of the MIBC data aggregation; at the first glance everything points to what @AndyAyersMS described - merging data containing block information with data containing edge information.

Feel free to disable this assert if it helps move things along, and open an issue for follow-up.

@trylek trylek mentioned this pull request Apr 6, 2023
Closed
@trylek
Copy link
Member

trylek commented Apr 6, 2023

Thanks @AndyAyersMS for your feedback, that sounds reasonable to me. I have verified that commenting out the assertion check fixes the problem. I have created a new issue

#84446

to track this, I'll publish the PR in a bit.

This was referenced Apr 6, 2023
Closed
Merged
@dotnet-maestro
Update dependencies from https://github.com/dotnet/msquic build 20230…
11b8041 
…331.1

System.Net.MsQuic.Transport
 From Version 8.0.0-alpha.1.23166.1 -> To Version 8.0.0-alpha.1.23181.1
@trylek
Copy link
Member

trylek commented Apr 7, 2023

I have just merged in the PR removing the assertion check, the CoreCLR build jobs should start passing now.

@trylek trylek closed this Apr 7, 2023
@trylek trylek reopened this Apr 7, 2023
@danmoseley
Copy link
Member

System.Net.Quic.Tests.MsQuicPlatformDetectionTests.SupportedWindowsPlatforms_IsSupportedIsTrue is still failing @CarnaViire @karelz

@ericstj
Copy link
Member

ericstj commented Apr 7, 2023

@CarnaViire looks like this got another Quic update and the tests are failing again:
image
https://dev.azure.com/dnceng-public/public/_build/results?buildId=231234&view=ms.vss-test-web.build-test-results-tab&runId=4385788&resultId=144479&paneView=debug

I pulled the logs from helix:
console.7bf6a32e.log
Looks like the QUIC version detection was failing.

While I was there I went ahead and debugged it, this TryLoad is failing:

runtime/src/libraries/System.Net.Quic/src/System/Net/Quic/Internal/MsQuicApi.cs

Lines 68 to 69 in dae6c24

if (!NativeLibrary.TryLoad($"{Interop.Libraries.MsQuic}.{s_minMsQuicVersion.Major}", typeof(MsQuicApi).Assembly, DllImportSearchPath.AssemblyDirectory, out IntPtr msQuicHandle) &&
!NativeLibrary.TryLoad(Interop.Libraries.MsQuic, typeof(MsQuicApi).Assembly, DllImportSearchPath.AssemblyDirectory, out msQuicHandle))

That's happening because there are no msquic.dll binary in the shared framework. If I drop the msquic.dll into the test's shared framework it fixes it.

If I have a look at the transport package that Quic comes from it seems that it was split up:
https://dev.azure.com/dnceng/public/_artifacts/feed/dotnet8-transport/NuGet/System.Net.MsQuic.Transport/overview/8.0.0-alpha.1.23166.1 contains binaries vs https://dev.azure.com/dnceng/public/_artifacts/feed/dotnet8-transport/NuGet/System.Net.MsQuic.Transport/overview/8.0.0-alpha.1.23181.1 has no binaries and instead has package references for each runtime package containing binaries.

Looks like @hoyosjs made this change here: dotnet/msquic#138
That will require update here:

runtime/src/libraries/System.Net.Quic/src/System.Net.Quic.csproj

Lines 150 to 153 in 0760f77

<NativeBinPlaceItem Include="$(PkgSystem_Net_MsQuic_Transport)\runtimes\win10-$(TargetArchitecture)\native\*"
Condition="'$(UseQuicTransportPackage)' == 'true'" />
<NativeBinPlaceItem Include="$(PkgMicrosoft_Native_Quic_MsQuic_Schannel)\build\native\bin\$(TargetArchitecture)\*"
Condition="'$(UseQuicTransportPackage)' != 'true'" />

@danmoseley
Copy link
Member 

    Wasm.Build.Tests.Blazor.MiscTests.DefaultTemplate_AOT_InProjectFile(config: "Debug") [FAIL]
      Assert.DoesNotContain() Failure
      Found:    Microsoft.JSInterop.WebAssembly.dll -> Microsoft.JSInterop.WebAssembly.dll.bc

@lewing
Copy link
Member

lewing commented Apr 7, 2023

See #83624 (comment) this failure isn't unique to this pr and the fix is in dotnet/installer#16005 but blocked by source build problems there. It should not be considered blocking here.

@EgorBo EgorBo mentioned this pull request Apr 10, 2023
Closed
@steveisok steveisok self-requested a review April 10, 2023 15:47
@steveisok steveisok merged commit 7b6ab05 into main Apr 10, 2023
@steveisok steveisok deleted the darc-main-41d2dc4d-4dcd-43dc-9026-d043b8ad94be branch April 10, 2023 15:51
This was referenced Apr 22, 2023
Closed
Closed
@ghost ghost locked as resolved and limited conversation to collaborators May 10, 2023
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@steveisok steveisok steveisok approved these changes

Assignees
No one assigned
Labels
area-codeflow for labeling automated codeflow
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.