Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Tell coverlet to respect the [DoesNotReturn] attribute for coverage purposes #84396

Merged
merged 2 commits into from
Apr 12, 2023

Conversation

stephentoub
Copy link
Member

No description provided.

@ghost ghost assigned stephentoub Apr 6, 2023
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Apr 6, 2023
@MarcoRossignoli
Copy link
Member

MarcoRossignoli commented Apr 6, 2023

We don't have a lot of tests on this feature and it's opt-in as explained off line, it was kindly offered by @kevin-montrose coverlet-coverage/coverlet#904

We could improve in case some use cases are missing cc: @daveMueller @petli @tonerdo

@ghost
Copy link

ghost commented Apr 7, 2023

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: stephentoub
Assignees: stephentoub
Labels:

area-Infrastructure-libraries, needs-area-label

Milestone: -

@danmoseley danmoseley removed the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Apr 7, 2023
@stephentoub stephentoub requested a review from ericstj April 7, 2023 16:13
@stephentoub stephentoub merged commit 314362e into dotnet:main Apr 12, 2023
@stephentoub stephentoub deleted the coverletdoesnotreturn branch April 12, 2023 13:01
@ghost ghost locked as resolved and limited conversation to collaborators May 12, 2023
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants