Fix OperatingSystemTest.TestIsOSPlatform_MacCatalyst #84842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It got broken by 3d160bc because the assert wasn't updated. Changed the code to verify the iOS/Catalyst conditions explicitly so this doesn't happen again.
dotnet-issue-labeler
bot
added
the
needs-area-label
ghost
assigned 
|
/azp run runtime-maccatalyst |
|
Azure Pipelines successfully started running 1 pipeline(s). |
steveisok
approved these changes
Apr 14, 2023
stephentoub
reviewed
Apr 17, 2023
| Assert.False(allResults[10]); // IsWasi() | ||
| for (int i = 0; i < allResults.Length; i++) | ||
| { | ||
| bool expected = (i == 4 || i == 5) ? true : false; // true for IsIOS() and IsMacCatalyst() |
There was a problem hiding this comment.
Suggested change
| bool expected = (i == 4 || i == 5) ? true : false; // true for IsIOS() and IsMacCatalyst() | |
| bool expected = i is 4 or 5; // true for IsIOS() and IsMacCatalyst() |
?
Might be cleaner to change allResults to instead be a Dictionary<string,bool>, where the string is the name of the Is method. The else case could still assert that only one value was true, and this case could assert that both "IsIOS" and "IsMacCatalyst" are true and everything else is false.
There was a problem hiding this comment.
Updated with your suggestion
stephentoub
approved these changes
Apr 17, 2023
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It got broken by 3d160bc because the length assert wasn't updated. Changed the code to verify the iOS/Catalyst conditions explicitly so this doesn't happen again.