Skip to content

Adding TimeProvider CreateCancellationTokenSource extension method #85131

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 24, 2023
Merged

Adding TimeProvider CreateCancellationTokenSource extension method #85131

merged 2 commits into from
Apr 24, 2023

Conversation

tarekgh
Copy link
Member

@tarekgh tarekgh commented Apr 20, 2023

Fixes #85080

@ghost ghost added needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners new-api-needs-documentation labels Apr 20, 2023
@ghost
Copy link

ghost commented Apr 20, 2023

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost ghost assigned tarekgh Apr 20, 2023
@tarekgh tarekgh added area-System.DateTime and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Apr 20, 2023
@ghost
Copy link

ghost commented Apr 20, 2023

Tagging subscribers to this area: @dotnet/area-system-datetime
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #85080

Author: tarekgh
Assignees: tarekgh
Labels:

new-api-needs-documentation, area-System.DateTime
Milestone: -

@tarekgh tarekgh requested a review from stephentoub April 20, 2023 23:19
@tarekgh tarekgh added this to the 8.0.0 milestone Apr 20, 2023
@tarekgh
Copy link
Member Author

tarekgh commented Apr 20, 2023

CC @sebastienros

@build-analysis build-analysis bot mentioned this pull request Apr 21, 2023
Closed
@tarekgh tarekgh merged commit 1f8d401 into dotnet:main Apr 24, 2023
@ghost ghost locked as resolved and limited conversation to collaborators May 24, 2023
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@JamesNK JamesNK JamesNK left review comments

@stephentoub stephentoub stephentoub left review comments

@eiriktsarpalis eiriktsarpalis eiriktsarpalis left review comments

@danmoseley danmoseley danmoseley left review comments

@sebastienros sebastienros sebastienros approved these changes

Assignees

@tarekgh tarekgh

Labels
area-System.DateTime new-api-needs-documentation
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.

[API Proposal]: Introduce TimeProvider extension method to create a CTS to be cancelled after a specified time period.
6 participants
@tarekgh @JamesNK @sebastienros @stephentoub @eiriktsarpalis @danmoseley