Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Intrinsify Unsafe.Read/Write/Copy, handle struct BitCast #85562

Merged
merged 64 commits into from
Jul 23, 2023
Merged

Intrinsify Unsafe.Read/Write/Copy, handle struct BitCast #85562

merged 64 commits into from
Jul 23, 2023

Conversation

MichalPetryka
Copy link
Contributor

@MichalPetryka MichalPetryka commented Apr 29, 2023 •
edited
Loading

Implements Unsafe.Read/Write/Copy (and the unaligned versions) as JIT intrinsics.

Fixes bugs with small type params not being correctly extended in bitcast.

Handles structs in Unsafe.BitCast via intrinsic.

Contributes to #69220.
Fixes #55357.

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Apr 29, 2023
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Apr 29, 2023
@ghost
Copy link

ghost commented Apr 29, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

Implements Unsafe.Read/Write (and the unaligned versions) as JIT intrinsics.

Handles structs in Unsafe.BitCast via intrinsic.

Contributes to #69220.

Author: MichalPetryka
Assignees: -
Labels:

area-CodeGen-coreclr, community-contribution
Milestone: -

@MichalPetryka MichalPetryka marked this pull request as ready for review April 30, 2023 18:35
SingleAccretion
SingleAccretion reviewed Apr 30, 2023
View reviewed changes
@MichalPetryka MichalPetryka mentioned this pull request May 1, 2023
Closed
@MichalPetryka
Copy link
Contributor Author

I'll be unable to respond to reviews for a few weeks, I've asked @thatbakamono to apply any feedback though.

@build-analysis build-analysis bot mentioned this pull request May 3, 2023
Closed
This was referenced Jul 14, 2023
Closed
Closed
@MichalPetryka MichalPetryka mentioned this pull request Jul 16, 2023
Closed
@EgorBo
Copy link
Member

EgorBo commented Jul 16, 2023

/azp run runtime-coreclr outerloop, runtime-extra-platforms, runtime-coreclr pgostress

@azure-pipelines
Copy link

No commit pushedDate could be found for PR 85562 in repo dotnet/runtime

@EgorBo
Copy link
Member

EgorBo commented Jul 16, 2023

/azp run runtime-coreclr outerloop

@azure-pipelines
Copy link

No commit pushedDate could be found for PR 85562 in repo dotnet/runtime

@EgorBo
Copy link
Member

EgorBo commented Jul 16, 2023

/azp run runtime-coreclr jitstress

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@build-analysis build-analysis bot mentioned this pull request Jul 17, 2023
Closed
This was referenced Jul 18, 2023
Open
Closed
Closed
@EgorBo
Copy link
Member

EgorBo commented Jul 22, 2023

Can you please rebase it - CI should be better now

@MichalPetryka
Copy link
Contributor Author

@MihuBot

@MihuBot MihuBot mentioned this pull request Jul 22, 2023
Open
@EgorBo EgorBo merged commit 8d2535d into dotnet:main Jul 23, 2023
@EgorBo
Copy link
Member

EgorBo commented Jul 23, 2023

Thanks!

@tannergooding tannergooding mentioned this pull request Jul 23, 2023
Open
@MichalPetryka MichalPetryka mentioned this pull request Jul 23, 2023
Open
@radical radical mentioned this pull request Jul 24, 2023
Closed
@EgorBo EgorBo mentioned this pull request Jul 27, 2023
Closed
@cincuranet cincuranet mentioned this pull request Aug 1, 2023
Closed
@AndyAyersMS
Copy link
Member

Improvments:

@AndyAyersMS
Copy link
Member

Possible regressions:

@ghost ghost locked as resolved and limited conversation to collaborators Aug 31, 2023
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@SingleAccretion SingleAccretion SingleAccretion left review comments

@EgorBo EgorBo EgorBo approved these changes

Assignees

@EgorBo EgorBo

@MichalPetryka MichalPetryka

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unsafe.As resulting in lots of unnecessary moves.
5 participants
@MichalPetryka @JulieLeeMSFT @EgorBo @AndyAyersMS @SingleAccretion