Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

JIT: Fix modelling of exceptions thrown by INDEX_ADDR #85646

Merged
merged 2 commits into from
May 2, 2023

Conversation

jakobbotsch
Copy link
Member

@jakobbotsch jakobbotsch commented May 2, 2023

Fix #85645

Expect regressions from no longer being able to make profitable reorderings of some call args in MinOpts.

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label May 2, 2023
@ghost ghost assigned jakobbotsch May 2, 2023
@ghost
Copy link

ghost commented May 2, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: jakobbotsch
Assignees: -
Labels:

area-CodeGen-coreclr

Milestone: -

@jakobbotsch
Copy link
Member Author

Diffs. Only diffs in MinOpts as expected since INDEX_ADDR are expanded before we call OperExceptions when optimizing. The diffs are also mostly in some test cases.

cc @dotnet/jit-contrib PTAL @AndyAyersMS

@jakobbotsch
Copy link
Member Author

It looks like Andy is out, can you take a look @EgorBo? Simple change.

@jakobbotsch jakobbotsch merged commit 8290921 into dotnet:main May 2, 2023
@jakobbotsch jakobbotsch deleted the fix-85645 branch May 2, 2023 20:28
@ghost ghost locked as resolved and limited conversation to collaborators Jun 2, 2023
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JIT: Incorrect exception modelling for INDEX_ADDR
2 participants