Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update PropertyTabAttribute.Equals() nullability #85896

Merged
merged 1 commit into from
May 9, 2023

Conversation

hrrrrustic
Copy link
Contributor

Close #55178

@dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label May 7, 2023
@ghost
Copy link

ghost commented May 7, 2023

Tagging subscribers to this area: @dotnet/area-system-componentmodel
See info in area-owners.md if you want to be subscribed.

Issue Details

Close #55178

Author: hrrrrustic
Assignees: -
Labels:

area-System.ComponentModel, new-api-needs-documentation

Milestone: -

Copy link
Contributor

@buyaa-n buyaa-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@buyaa-n
Copy link
Contributor

buyaa-n commented May 9, 2023

Failures unrelated and reported

@buyaa-n buyaa-n merged commit 5318f75 into dotnet:main May 9, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Jun 8, 2023
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
area-System.ComponentModel community-contribution Indicates that the PR has been added by a community member new-api-needs-documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PropertyTabAttribute.Equals(PropertyTabAttribute other) should likely accept null
2 participants