Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[wasm] InstallWorkloadFromArtifacts: remove unnecessary workaround #86191

Merged
merged 1 commit into from
May 13, 2023

Conversation

radical
Copy link
Member

@radical radical commented May 12, 2023

Prompted by WBT failing with:

/Users/ankj/dev/r2/eng/testing/workloads-testing.targets(191,5): error : Could not find IncludedWorkloadManifests.txt in /Users/ankj/dev/r2/artifacts/bin/dotnet-none/

.. which seems to have been renamed to KnownWorkloadManifests.txt.

Fixes #86192 .

Prompted by WBT failing with:
```
/Users/ankj/dev/r2/eng/testing/workloads-testing.targets(191,5): error : Could not find IncludedWorkloadManifests.txt in /Users/ankj/dev/r2/artifacts/bin/dotnet-none/
```

.. which seems to been renamed to `KnownWorkloadManifests.txt`.
@radical radical requested review from lewing and steveisok May 12, 2023 23:42
@ghost ghost assigned radical May 12, 2023
@radical radical added this to the 8.0.0 milestone May 12, 2023
@ghost
Copy link

ghost commented May 12, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Prompted by WBT failing with:

/Users/ankj/dev/r2/eng/testing/workloads-testing.targets(191,5): error : Could not find IncludedWorkloadManifests.txt in /Users/ankj/dev/r2/artifacts/bin/dotnet-none/

.. which seems to been renamed to KnownWorkloadManifests.txt.

Author: radical
Assignees: radical
Labels:

arch-wasm, area-Infrastructure-mono, test-failure

Milestone: -

@lewing
Copy link
Member

lewing commented May 13, 2023

dotnet/sdk#31949

@lewing lewing merged commit b677265 into dotnet:main May 13, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Jun 12, 2023
@radical radical deleted the fix-wbt-build branch August 22, 2023 14:58
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[wasm] WBT failing to install with Could not find IncludedWorkloadManifests.txt because the file was renamed
2 participants