-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Multiple GDV: ignore non-inlineable candidates #86835
Conversation
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsContributes to #86769 The current logic used to give on all of them if at least one of the candidates were non inlineable (for any reason) public interface IValue
{
int GetValue();
}
public class MyClass1 : IValue
{
public int GetValue() => 10;
}
public class MyClass2 : IValue
{
[MethodImpl(MethodImplOptions.NoInlining)]
public int GetValue() => 50;
}
public class MyClass3 : IValue
{
public int GetValue() => 100;
}
|
@AndyAyersMS PTAL |
@AndyAyersMS Thanks! Good idea, not sure why I decided to introduce those struct copies. Addressed via 2d3395e - it also simplified the code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Contributes to #86769
The current logic used to give up on all of them if at least one of the candidates was non-inlineable (for any reason)
E.g.:
Was:
Now: