Fix assert failure in grow_heap_segment for SVR GC. #86889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For my previous change, I overlooked the fact that we may call grow_heap_segment from within should_proceed_for_no_gc(), so it's too late to turn off gradual_decommit_in_progress_p after this method returns.
ghost
assigned 
|
Tagging subscribers to this area: @dotnet/gc Issue DetailsFor my previous change, I overlooked the fact that we may call grow_heap_segment from within The fix is to turn off
|
mangod9
reviewed
May 30, 2023
mangod9
approved these changes
May 30, 2023
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For my previous change, I overlooked the fact that we may call grow_heap_segment from within
should_proceed_for_no_gc(), so it's too late to turn offgradual_decommit_in_progress_pafter this method returns.The fix is to turn off
gradual_decommit_in_progress_pat the beginning ofshould_proceed_for_no_gc(). If it turns out we still want to do a GC, the flag will get turned on again by that GC, if appropriate.