[NativeAOT] A few cleanups in stack walking on Windows #86917
Conversation
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas Issue DetailsA subset of #86690 As discussed in: #86690 (comment)
|
| @@ -10,17 +10,17 @@ namespace System | |||
| [StructLayout(LayoutKind.Sequential)] | |||
| public struct RuntimeTypeHandle | |||
| { | |||
| private EETypePtr _pEEType; | |||
| private IntPtr _pEEType; | |||
There was a problem hiding this comment.
What motivated this change? We have another copy at src\coreclr\nativeaot\Runtime.Base\src\System\RuntimeTypeHandle.cs that can be updated as well.
Also, while you are on it - could you please delete this comment
private IntPtr _value; to the top in that file?
There was a problem hiding this comment.
What motivated this change?
I was looking at what stack traces do allocations and at some point I had doubts that stacks are correct. So I tried to look at optimized=false traces. It was mostly the same, in terms of allocating paths, except a few cases of boxing, that are otherwise optimized.
What surprised me is the wrapping/unwrapping of EETypePtr in the RuntimeTypeHandle - it was near the top. It looks like a common operation, so I "fixed" it to not clutter the profile.
This change is not required, since JIT can optimize this away, but I figured it is better if I keep "fixed" variant.
| @@ -10,17 +10,17 @@ namespace System | |||
| [StructLayout(LayoutKind.Sequential)] | |||
| public struct RuntimeTypeHandle | |||
| { | |||
| private EETypePtr _pEEType; | |||
| private IntPtr _pEEType; | |||
There was a problem hiding this comment.
Also, it may be nice to rename _pEEType to _value so that it is in sync with the full implementation.
|
Thanks! |
ghost
locked as resolved and limited conversation to collaborators
A subset of #86690
As discussed in: #86690 (comment)