Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Apply source build patch #87226

Merged
merged 1 commit into from
Jun 7, 2023
Merged

Apply source build patch #87226

merged 1 commit into from
Jun 7, 2023

Conversation

jkotas
Copy link
Member

@jkotas jkotas commented Jun 7, 2023

Fixes #83695

@ghost
Copy link

ghost commented Jun 7, 2023

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #83695

Author: jkotas
Assignees: -
Labels:

area-NativeAOT-coreclr

Milestone: -

@@ -10,8 +10,8 @@
<!-- BEGIN: Workaround for https://github.com/dotnet/runtime/issues/67742 -->
<PropertyGroup Condition="'$(BuildingInsideVisualStudio)' != 'true'">
<PublishDir>$(RuntimeBinDir)ilc-published/</PublishDir>
<NativeAotSupported Condition="'$(TargetOS)' != 'windows' and '$(TargetOS)' != 'linux' and '$(TargetOS)' != 'osx'">false</NativeAotSupported>
<NativeAotSupported Condition="'$(TargetArchitecture)' != 'x64'">false</NativeAotSupported>
<!-- Can't use NativeAOT in source build yet https://github.com/dotnet/runtime/issues/66859 -->
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made this to match

<!-- Can't use NativeAOT in source build yet https://github.com/dotnet/runtime/issues/66859 -->
<NativeAotSupported Condition="'$(DotNetBuildFromSource)' == 'true'">false</NativeAotSupported>

@jkotas jkotas requested a review from MichalStrehovsky June 7, 2023 19:12
@jkotas jkotas merged commit b8e0ce0 into dotnet:main Jun 7, 2023
@jkotas jkotas deleted the source-build branch June 20, 2023 16:33
@ghost ghost locked as resolved and limited conversation to collaborators Jul 20, 2023
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failure when building self-hosted NativeAOT compiler changes with 8.0 Preview 2 SDK
2 participants