Fix runtime-extra-platforms failures related to HybridGlobalization #87913
Conversation
mkhamoyan
added
os-ios
|
Tagging subscribers to 'os-tvos': @steveisok, @akoeplinger Issue DetailsFix failures on runtime-extra-platforms after merging #86895
|
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
mkhamoyan
changed the title
| @@ -114,12 +114,15 @@ Range GlobalizationNative_IndexOfNative(const uint16_t* localeName, int32_t lNam | |||
| const uint16_t* lpSource, int32_t cwSourceLength, int32_t comparisonOptions, int32_t fromBeginning) | |||
| { | |||
| assert(cwTargetLength >= 0); | |||
| Range result = {-2, 0}; | |||
| Range result = {-1, 0}; | |||
There was a problem hiding this comment.
What do these magic numbers of -1, -2, -3, etc. mean?
There was a problem hiding this comment.
Added ErrorCodes enum to make it clear.
|
/azp run runtime-ioslike |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| @@ -114,12 +121,15 @@ Range GlobalizationNative_IndexOfNative(const uint16_t* localeName, int32_t lNam | |||
| const uint16_t* lpSource, int32_t cwSourceLength, int32_t comparisonOptions, int32_t fromBeginning) | |||
| { | |||
| assert(cwTargetLength >= 0); | |||
| Range result = {-2, 0}; | |||
| Range result = {ERROR_INDEX_NOT_FOUND, 0}; | |||
There was a problem hiding this comment.
Shouldn't this be ERROR_COMPARISON_OPTIONS_NOT_FOUND as previously the value was -2?
There was a problem hiding this comment.
Never mind, that was actually the fix in the first place.
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Failures are not related. |
ghost
locked as resolved and limited conversation to collaborators
Fix failures on runtime-extra-platforms after merging #86895
Return ERROR_COMPARISON_OPTIONS_NOT_FOUND only when options are not found and ERROR_INDEX_NOT_FOUND when substring is not found.