[release/7.0-staging][mono][debugger] Showing "Frame not in module" after vscode-js-debug bump on VS #88336
Conversation
ghost
assigned 
|
Tagging subscribers to this area: @thaystg |
|
/backport to release/6.0-staging |
|
Started backporting to release/6.0-staging: https://github.com/dotnet/runtime/actions/runs/5446722096 |
|
@thaystg backporting to release/6.0-staging failed, the patch most likely resulted in conflicts: $ git am --3way --ignore-whitespace --keep-non-patch changes.patch
Applying: Backport #87154 #87870 #87979
Using index info to reconstruct a base tree...
M src/mono/wasm/debugger/BrowserDebugProxy/DevToolsHelper.cs
A src/mono/wasm/debugger/BrowserDebugProxy/Firefox/FirefoxMonoProxy.cs
M src/mono/wasm/debugger/BrowserDebugProxy/MonoProxy.cs
Falling back to patching base and 3-way merge...
Auto-merging src/mono/wasm/debugger/BrowserDebugProxy/MonoProxy.cs
CONFLICT (content): Merge conflict in src/mono/wasm/debugger/BrowserDebugProxy/MonoProxy.cs
CONFLICT (modify/delete): src/mono/wasm/debugger/BrowserDebugProxy/Firefox/FirefoxMonoProxy.cs deleted in HEAD and modified in Backport #87154 #87870 #87979. Version Backport #87154 #87870 #87979 of src/mono/wasm/debugger/BrowserDebugProxy/Firefox/FirefoxMonoProxy.cs left in tree.
Auto-merging src/mono/wasm/debugger/BrowserDebugProxy/DevToolsHelper.cs
CONFLICT (content): Merge conflict in src/mono/wasm/debugger/BrowserDebugProxy/DevToolsHelper.cs
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Backport #87154 #87870 #87979
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128Please backport manually! |
|
@thaystg an error occurred while backporting to release/6.0-staging, please check the run log for details! Error: git am failed, most likely due to a merge conflict. |
rbhanda
added
Servicing-approved
|
@thaystg @ilonatommy - Reminder: Code Complete for the August Release is tomorrow Monday July 10th. If you intend to include this fix in that release, please make sure to merge it before 4pm because that's when I'll start the staging merge process into internal. |
Backport #87154 #87870 #87979
Customer Impact
Fixes #87407.
ExecutionContextDestroy and ExecutionContextCleared were CDP messages ignored by vscode-js-debug, and now they implemented the correct support for it, so we also need to implement the correct support on BrowserDebugProxy otherwise it will not be possible to debug Blazor apps with authentication.
Testing:
Try setting a breakpoint on a page guarded by authentication.
Risk
Medium, It's removing the debugging contexts that are not valid anymore.