Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[wasm][debugger] Fix regex for helix retries when chrome fails to launch #88632

Merged
merged 1 commit into from
Jul 11, 2023

Conversation

radical
Copy link
Member

@radical radical commented Jul 10, 2023

The regex was slightly off, and expected at least two spaces between chrome and unexpected.

Fixes #87053 .

@radical radical added arch-wasm WebAssembly architecture area-Debugger-mono labels Jul 10, 2023
@ghost ghost assigned radical Jul 10, 2023
@ghost
Copy link

ghost commented Jul 10, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: radical
Assignees: -
Labels:

arch-wasm, area-Debugger-mono

Milestone: -

@radical radical requested review from lewing and thaystg July 10, 2023 21:47
@lewing
Copy link
Member

lewing commented Jul 11, 2023

failures are unrelated

@lewing lewing merged commit 17a5d43 into dotnet:main Jul 11, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Aug 13, 2023
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
arch-wasm WebAssembly architecture area-Debugger-mono
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[mono][dbg] EvaluateConstantValueUsingRuntimeEvaluate test crash on Chrome
2 participants