Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove extra checks for known types in log formatter #89000

Merged
merged 1 commit into from
Jul 17, 2023
Merged

Remove extra checks for known types in log formatter #89000

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions src/libraries/Microsoft.Extensions.Logging.Abstractions/src/LogValuesFormatter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,13 +265,6 @@ private static object FormatArgument(object? value)

private static bool TryFormatArgumentIfNullOrEnumerable<T>(T? value, [NotNullWhen(true)] ref object? stringValue)
{
// Avoiding boxing of known types
if (typeof(T).IsPrimitive || typeof(T).IsEnum)
{
stringValue = null;
return false;
}

if (value == null)
{
stringValue = NullValue;
Expand Down