-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
WIP: [mono][tests] Enable trimming for libraries and functional tests on CI #92645
Conversation
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries Issue DetailsThis PR is currently marked as a DescriptionThe PR will be used to incrementally test enabling trimming for libraries and functional tests when targeting ios/tvos platforms on CI. To enable trimming during test builds we should set: To run a libraries test locally:
IMPORTANT!!!The initial commit has to be reverted as it disables the default CI trigger so that we do not polute the queues. Should fix: #91923
|
/cc: @simonrozsival @mdh1418 |
Tagging subscribers to this area: @directhex Issue DetailsThis PR is currently marked as a DescriptionThe PR will be used to incrementally test enabling trimming for libraries and functional tests when targeting ios/tvos platforms on CI. To enable trimming during test builds we should set: To run a libraries test locally:
IMPORTANT!!!The initial commit has to be reverted as it disables the default CI trigger so that we do not polute the queues. Should fix: #91923
|
/azp run runtime-ioslike |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run runtime-ioslike |
Azure Pipelines successfully started running 1 pipeline(s). |
Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it. |
This PR is currently marked as a
DRAFT
and is intended just for testing.Description
The PR will be used to incrementally test enabling trimming for libraries and functional tests when targeting ios/tvos platforms on CI. To enable trimming during test builds we should set:
-p:EnableAggressiveTrimming=true
, however it was reported that some tests depend on not being trimmed in: #91923 which we should investigate and root/fix the failing tests accordingly.To run a libraries test locally:
!IMPORTANT!
The initial commits have to be reverted as they disable the default CI triggers, which was done to avoid polluting the queues.
Incremental testing can be done by running:
/azp run runtime-ioslike
Tentative plan
System.Runtime.Numerics.Tests
- 3 failing testsSystem.Runtime.Tests
- 11 failing testsiOS.Device.Aot.Test
iOS.Device.ExportManagedSymbols.Test
Current state
ios-arm64
with trimmingFailing work items:
NOTE: both functional test from above seem to run the correctly and return the expected return value, but XHarness reports
XHarness exit code: 92 (TCP_CONNECTION_FAILED)
marking the test as failed.Should fix: #91923