Optimize Interlocked.CompareExchange use in Task #93953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
community-contribution
|
Tagging subscribers to this area: @dotnet/area-system-threading-tasks Issue DetailsAlways use
|
This was referenced Oct 25, 2023
stephentoub
reviewed
Jan 29, 2024
src/libraries/System.Private.CoreLib/src/System/Threading/Tasks/Task.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Jan 29, 2024
stephentoub
approved these changes
Jan 29, 2024
This was referenced Jan 30, 2024
Closed
|
@pentp, just wanted to make sure you had seen Stephen's comments. Are you planning on fixing those here in this PR or would you prefer to push up a second PR after this one is merged since they're relatively minor? |
stephentoub
force-pushed
the
task-interlocked
branch
from
53a3515 to
6f585b1
Compare
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always use
Interlocked.CompareExchangeresult when possible instead of re-reading the value.Use
m_stateObjectfor storingWhenAllPromisefailed/canceled tasks.