Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Revert "Revert "Error out if SelfContained is not specified for Native AOT publish"" #96206

Merged

Conversation

MichalStrehovsky
Copy link
Member

Reverts #95881

I fixed the test in the SDK repo that was failing because of this so we should be able to restore this.

Cc @dotnet/ilc-contrib

@ghost ghost added the linkable-framework Issues associated with delivering a linker friendly framework label Dec 20, 2023
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-Tools-ILLink .NET linker development as well as trimming analyzers label Dec 20, 2023
@ghost
Copy link

ghost commented Dec 20, 2023

Tagging subscribers to 'linkable-framework': @eerhardt, @vitek-karas, @LakshanF, @sbomer, @joperezr, @marek-safar
See info in area-owners.md if you want to be subscribed.

Issue Details

Reverts #95881

I fixed the test in the SDK repo that was failing because of this so we should be able to restore this.

Cc @dotnet/ilc-contrib

Author: MichalStrehovsky
Assignees: -
Labels:

linkable-framework

Milestone: -

Copy link
Member

@sbomer sbomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MichalStrehovsky MichalStrehovsky merged commit 3a5bea5 into main Dec 20, 2023
@MichalStrehovsky MichalStrehovsky deleted the revert-95881-revert-95496-MichalStrehovsky-patch-1 branch December 20, 2023 21:51
@github-actions github-actions bot locked and limited conversation to collaborators Jan 20, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
area-Tools-ILLink .NET linker development as well as trimming analyzers linkable-framework Issues associated with delivering a linker friendly framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants