Remove xunit-specific Rosyln analyzer testing packages #97220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Microsoft.CodeAnalysis.CSharp.Analyzer.Testing.Xunit brings in an older xunit reference that is not compatible in some cases, we've hit issues with it while upgrading our xunit reference in the past. As mentioned in dotnet/roslyn-sdk#1099 (comment) we can use the generic testing package instead. The only difference is the exception type thrown when an assert fails, e.g. the test throws `InvalidOperationException` instead of `Xunit.Sdk.EqualException` but we still get actual vs. expected exception messages so this is enough for us.
akoeplinger
requested review from
marek-safar,
lewing and
pavelsavara
as code owners
|
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries Issue DetailsMicrosoft.CodeAnalysis.CSharp.Analyzer.Testing.Xunit brings in an older xunit reference that is not compatible in some cases, we've hit issues with it while upgrading our xunit reference in the past. As mentioned in dotnet/roslyn-sdk#1099 (comment) we can use the generic testing package instead. The only difference is the exception type thrown when an assert fails, e.g. the test throws
|
ghost
assigned 
This was referenced Jan 19, 2024
tmds
pushed a commit
to tmds/runtime
that referenced
this pull request
Jan 23, 2024
Microsoft.CodeAnalysis.CSharp.Analyzer.Testing.Xunit brings in an older xunit reference that is not compatible in some cases, we've hit issues with it while upgrading our xunit reference in the past. As mentioned in dotnet/roslyn-sdk#1099 (comment) we can use the generic testing package instead. The only difference is the exception type thrown when an assert fails, e.g. the test throws `InvalidOperationException` instead of `Xunit.Sdk.EqualException` but we still get actual vs. expected exception messages so this is enough for us.
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Microsoft.CodeAnalysis.CSharp.Analyzer.Testing.Xunit brings in an older xunit reference that is not compatible in some cases, we've hit issues with it while upgrading our xunit reference in the past.
As mentioned in dotnet/roslyn-sdk#1099 (comment) we can use the generic testing package instead. The only difference is the exception type thrown when an assert fails, e.g. the test throws
InvalidOperationExceptioninstead ofXunit.Sdk.EqualExceptionbut we still get actual vs. expected exception messages so this is enough for us.