Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add ARM64 encodings for group IF_SVE_BH_3A,3B,3B_A #98764

Merged
merged 7 commits into from
Feb 29, 2024
Merged

Add ARM64 encodings for group IF_SVE_BH_3A,3B,3B_A #98764

merged 7 commits into from
Feb 29, 2024

Conversation

snickolls-arm
Copy link
Contributor

Covers encodings for a few SVE variants of the adr instruction.

Matching capstone output:

adr z4.d, [z2.d, z0.d]
adr z29.s, [z1.s, z10.s, lsl #1]
adr z9.d, [z7.d, z9.d, sxtw]
adr z12.d, [z3.d, z5.d, sxtw #2]
adr z9.d, [z10.d, z14.d, uxtw]
adr z3.d, [z15.d, z11.d, uxtw #3]

Contributing towards #94549.

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Feb 21, 2024
@ghost
Copy link

ghost commented Feb 21, 2024

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

Covers encodings for a few SVE variants of the adr instruction.

Matching capstone output:

adr z4.d, [z2.d, z0.d]
adr z29.s, [z1.s, z10.s, lsl #1]
adr z9.d, [z7.d, z9.d, sxtw]
adr z12.d, [z3.d, z5.d, sxtw #2]
adr z9.d, [z10.d, z14.d, uxtw]
adr z3.d, [z15.d, z11.d, uxtw #3]

Contributing towards #94549.

Author: snickolls-arm
Assignees: -
Labels:

area-CodeGen-coreclr
Milestone: -

@snickolls-arm
Copy link
Contributor Author

@a74nh @kunalspathak @dotnet/arm64-contrib

a74nh
a74nh approved these changes Feb 22, 2024
View reviewed changes
Copy link
Contributor

@a74nh a74nh left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, LGTM

(EDIT: Didn't mean to approve until the change is made)

src/coreclr/jit/emitarm64.cpp Outdated
ssize_t imm,
insOpts opt /* = INS_OPTS_NONE */,
emitAttr attrReg2 /* = EA_UNKNOWN */)
void emitter::emitIns_R_R_R_I(instruction ins,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change isn't needed as your not touching this function otherwise.

@huoyaoyuan huoyaoyuan added the arm-sve Work related to arm64 SVE/SVE2 support label Feb 23, 2024
@teo-tsirpanis teo-tsirpanis added the community-contribution Indicates that the PR has been added by a community member label Feb 26, 2024
@kunalspathak kunalspathak mentioned this pull request Feb 27, 2024
Closed
@TIHan TIHan mentioned this pull request Feb 27, 2024
Closed
kunalspathak
kunalspathak approved these changes Feb 27, 2024
View reviewed changes
Copy link
Member

@kunalspathak kunalspathak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kunalspathak
Copy link
Member

@snickolls-arm - can you please pull the latest main and merge them?

@kunalspathak
Copy link
Member

superpmi failures seems to be infra issue.

@kunalspathak kunalspathak merged commit fd48b6f into dotnet:main Feb 29, 2024
125 of 129 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 31, 2024
@snickolls-arm snickolls-arm deleted the github-IF_SVE_BH branch January 17, 2025 16:07
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@a74nh a74nh a74nh approved these changes

@kunalspathak kunalspathak kunalspathak approved these changes

Assignees
No one assigned
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI arm-sve Work related to arm64 SVE/SVE2 support community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@snickolls-arm @kunalspathak @a74nh @huoyaoyuan @teo-tsirpanis