Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Disable source gen unit tests on mono. #98994

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

eiriktsarpalis
Copy link
Member

Fix #92467.

@lewing
Copy link
Member

lewing commented Feb 27, 2024

You realize this isn't failing just on mono right? https://helixre107v0xdcypoyl9e7f.blob.core.windows.net/dotnet-runtime-refs-pull-97641-merge-94c64fb616f5450fa3/System.Text.Json.SourceGeneration.Roslyn4.4.Unit.Tests/1/console.ec1a3b8f.log?helixlogtype=result - Or at least that issue is picking up more failures (I see the tests are disabled on coreclr too)

@eiriktsarpalis
Copy link
Member Author

Hmm, we had disabled the tests against checked builds of CoreCLR in reaction to #71962, but I wonder if we might want to disable it for x86 hardware as well.

@akoeplinger
Copy link
Member

Yeah it looks like x86 is the common denominator here, not the runtime.

@eiriktsarpalis
Copy link
Member Author

Do we have a good way of skipping x86 on test classes wholesale? Seems like only ConditionalFact and ConditionalTheory allow this on a test-by-test basis.

@eiriktsarpalis
Copy link
Member Author

Regardless, I'll merge this PR for now since mono test runs are impacted regardless of architecture.

@eiriktsarpalis eiriktsarpalis merged commit 5742895 into dotnet:main Feb 28, 2024
111 checks passed
@akoeplinger
Copy link
Member

@eiriktsarpalis you can use ConditionalClass for that.

@eiriktsarpalis eiriktsarpalis deleted the disable-stj-unittests branch February 28, 2024 20:12
@github-actions github-actions bot locked and limited conversation to collaborators Mar 30, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[mono][tvos] OOM in System.IO.Tests.MemoryStreamTests
5 participants