-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Disable source gen unit tests on mono. #98994
Disable source gen unit tests on mono. #98994
Conversation
You realize this isn't failing just on mono right? https://helixre107v0xdcypoyl9e7f.blob.core.windows.net/dotnet-runtime-refs-pull-97641-merge-94c64fb616f5450fa3/System.Text.Json.SourceGeneration.Roslyn4.4.Unit.Tests/1/console.ec1a3b8f.log?helixlogtype=result - Or at least that issue is picking up more failures (I see the tests are disabled on coreclr too) |
Hmm, we had disabled the tests against checked builds of CoreCLR in reaction to #71962, but I wonder if we might want to disable it for x86 hardware as well. |
Yeah it looks like x86 is the common denominator here, not the runtime. |
Do we have a good way of skipping x86 on test classes wholesale? Seems like only |
Regardless, I'll merge this PR for now since mono test runs are impacted regardless of architecture. |
@eiriktsarpalis you can use |
Fix #92467.