Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Ensure Array.Resize creates an array of the same type as the incoming array #99021

Closed
wants to merge 1 commit into from
Closed

Ensure Array.Resize creates an array of the same type as the incoming array #99021

wants to merge 1 commit into from

Conversation

xtqqczze
Copy link
Contributor

@xtqqczze xtqqczze commented Feb 27, 2024 •
edited
Loading

Likely a breaking change.

@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Feb 27, 2024
@teo-tsirpanis teo-tsirpanis added area-System.Runtime and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Feb 27, 2024
@ghost
Copy link

ghost commented Feb 27, 2024

Tagging subscribers to this area: @dotnet/area-system-runtime
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: xtqqczze
Assignees: -
Labels:

area-System.Runtime
Milestone: -

@teo-tsirpanis teo-tsirpanis added the community-contribution Indicates that the PR has been added by a community member label Feb 27, 2024
@xtqqczze
Copy link
Contributor Author

Related: dotnet/docs#38474

@xtqqczze
Copy link
Contributor Author

Reproduction of issue: https://sharplab.io/#v2:EYLgxg9gTgpgtADwGwBYA0AXEUCuA7AHwAEAmARgFgAoa6gSzwwG0BdAAgEMoo2BeNgBQNmLAJQCAgtw4BPUWzwwA7qzYBvNmRxsAvgG5qRMgE4BXKADoA4jAwAVGQAcYA0aINUpUWRYBKMAGc6AC8XWAAzTm40TXdDEzNua1sHZ1c4z2kZP0CQsJhI8xiSDKNTc2T7Jxc3Dy8ffyDQgQioqBiyUoSKmyq02qA==

@build-analysis build-analysis bot mentioned this pull request Feb 28, 2024
Closed
@jkotas
Copy link
Member

jkotas commented Feb 28, 2024

Related: dotnet/docs#38474

RuntimeHelpers.GetSubArray API was introduced recently to support recently introduced C# feature and the breaking change was taken to align with the design of C# feature.

You are proposing to change Array.Resize behavior that existed for 20 years. What is the justification for that?

This was referenced Feb 28, 2024
Closed
Open
Closed
@stephentoub stephentoub added the needs-author-action An issue or pull request that requires more info or actions from the author. label Mar 7, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

This pull request has been automatically marked no-recent-activity because it has not had any activity for 14 days. It will be closed if no further activity occurs within 14 more days. Any new comment (by anyone, not necessarily the author) will remove no-recent-activity.

@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

This pull request will now be closed since it had been marked no-recent-activity but received no further activity in the past 14 days. It is still possible to reopen or comment on the pull request, but please note that it will be locked if it remains inactive for another 30 days.

@github-actions github-actions bot locked and limited conversation to collaborators May 5, 2024
@xtqqczze xtqqczze deleted the Array-Resize branch July 7, 2024 11:39
@xtqqczze xtqqczze restored the Array-Resize branch July 7, 2024 11:39
@xtqqczze xtqqczze deleted the Array-Resize branch July 7, 2024 11:40
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers
No reviews
Assignees
No one assigned
Labels
area-System.Runtime community-contribution Indicates that the PR has been added by a community member needs-author-action An issue or pull request that requires more info or actions from the author. no-recent-activity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xtqqczze @jkotas @stephentoub @teo-tsirpanis