Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[release/8.0] Fix failing CertificateValidationRemoteServer.ConnectWithRevocation_WithCallback test (#99915) #99950

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

rzikm
Copy link
Member

@rzikm rzikm commented Mar 19, 2024

Closes #99425.

Manual port of #99915

Customer Impact

  • Customer reported
  • Found internally

Test only change to cleanup CI, see #99425

Regression

  • Yes
  • No

Surfaced likely after 72e5ae9.

Testing

Via CI.

Risk

Low, affected code is test only and does not ship with .NET.

…ithCallback test (dotnet#99915)

* Don't add empty Organization to Subject string

* Make sure testName is populated when creating test PKI

* Minor changes
Copy link
Contributor

Tagging subscribers to this area: @dotnet/ncl, @bartonjs, @vcsjones
See info in area-owners.md if you want to be subscribed.

@rzikm
Copy link
Member Author

rzikm commented Mar 19, 2024

CI passes, test only change (tell-mode), adding Servicing approved

@rzikm rzikm added the Servicing-approved Approved for servicing release label Mar 19, 2024
@rzikm rzikm merged commit 250354b into dotnet:release/8.0-staging Mar 20, 2024
90 of 113 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 20, 2024
@karelz karelz added this to the 8.0.x milestone Jun 24, 2024
@karelz karelz added the test-bug Problem in test source code (most likely) label Jun 25, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
area-System.Net.Security Servicing-approved Approved for servicing release test-bug Problem in test source code (most likely)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants