Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Generate error if TargetPlatformVersion is not a valid version when targeting Windows #12456

Closed
dsplaisted opened this issue Jul 14, 2020 · 0 comments · Fixed by #12632
Closed
Assignees
Milestone

Comments

@dsplaisted
Copy link
Member

dsplaisted commented Jul 14, 2020

If the TargetPlatform is Windows, we shouldn't allow arbitrary (likely invalid) version numbers for the TargetPlatformVersion. So we should have a list of known version numbers, and generate an error if the specified version number is not in the list. The list would likely include the following (and perhaps more):

  • 10.0.17763
  • 10.0.18362
  • 10.0.19041

The list of valid version numbers should also be used to define conditional compilation constants for previous versions of Windows. See the spec and the implementation PR which just needs SupportedTargetPlatform items to be defined appropriately to light up.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
2 participants