Error on unsupported Windows TargetPlatformVersion #12547
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsplaisted
reviewed
Jul 20, 2020
src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Windows.targets
Outdated
Show resolved
Hide resolved
src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.SupportedTargetPlatforms.props
Outdated
Show resolved
Hide resolved
sfoslund
force-pushed
the
SupportedPlatformVersions
branch
from
1c16974 to
42a8f90
Compare
wli3
approved these changes
Jul 21, 2020
dsplaisted
approved these changes
Jul 21, 2020
|
|
||
| <PropertyGroup> | ||
| <TargetPlatformVersionSupported Condition="'$(TargetPlatformVersionSupported)' == '' and '@(ValidTargetPlatformVersion)' != ''" >true</TargetPlatformVersionSupported> | ||
| <ValidTargetPlatformVersions Condition="'@(SupportedTargetPlatform)' != ''" >@(SupportedTargetPlatform, ', ')</ValidTargetPlatformVersions> |
There was a problem hiding this comment.
I think these should be joined by newlines, because comma isn't the right separator character for all locales. Confirm with @wli3, if he thinks this is OK then go ahead with it.
| @@ -193,6 +193,24 @@ Copyright (c) .NET Foundation. All rights reserved. | |||
| FormatArguments="$(MinimumOSPlatform);$(TargetPlatformVersion)"/> | |||
| </Target> | |||
|
|
|||
| <Target Name="_CheckForInvalidTargetPlatformVersion" | |||
There was a problem hiding this comment.
How does this interact with the invalid platform error? If you have an invalid platform and specify a TargetPlatformVersion, then we should only give you the invalid platform error, and not the invalid platform version error. Can you add a test case covering this?
|
Closing in favor of #12613 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12456