-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
NativeAot_hw_runs_with_no_warnings_when_PublishAot_is_enabled failing unexpectedly in 8.0.1xx and 9.0.1xx #46006
Comments
FWIW, we changed the test in main to ignore this warning: 6a07932 |
If this is Mac-only I wonder if it's an update to the Mac linker that could b e producing a new warning. cc @filipnavara |
There was a previous occurrence of this. I believe it was mixing of artifacts compiled on machines with different Xcode versions. I'll link back the comment with explanation if I find it. |
We still suppress warnings from ld on macOS so this (fortunately?) won't show up as a warning to the end user, just some text in stdout that most people won't even see: https://github.com/dotnet/runtime/blob/db7e9abb70208a67e686fdb6a593618649a2ed7e/src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.targets#L366C10-L370 |
I checked the compiler output. The entries in the |
@filipnavara Could you please share a link to the request? What are the PRs that the backport would have to include? |
I’m supportive of the backport as well — we should keep supported tooling compatible with current Apple tooling. |
The Unity request was communicated on Discord. I believe they integrated the backport in their fork (folded as the last commits of Unity-Technologies/runtime#270). The PRs that would need to be backported are dotnet/runtime#106800 for .NET 8, and dotnet/runtime#111530 for .NET 8 and .NET 9. |
These looks reasonable to backport. @filipnavara Could you please create the backport PRs? |
Thanks. I'll let my team know and we'll continue to merge on red for these failures in 8 and 9 PRs. |
Fixes have been merged. This should resolve itself in the sdk after runtime integration. |
@agocke merged for both 8 and 9 for the March release? So we should see this once the March changes flow publicly on release day in March? |
Merged to both 8 and 9. I assume this will make the march release, yes. |
Filing this so I can disable the test and merge on red
https://dev.azure.com/dnceng-public/public/_build/results?buildId=917233&view=results
https://dev.azure.com/dnceng-public/public/_build/results?buildId=917198&view=results
Known Issue Error Message
Fill the error message using step by step known issues guidance.
Report
Summary
Known issue validation
Build: 🔎 https://dev.azure.com/dnceng-public/public/_build/results?buildId=917233
Error message validated:
[The command output contained a result it should not have contained: warning
]Result validation: ✅ Known issue matched with the provided build.
Validation performed at: 1/16/2025 6:10:01 PM UTC
Report
Summary
Known issue validation
Build: 🔎 https://dev.azure.com/dnceng-public/public/_build/results?buildId=917233
Error message validated:
[The command output contained a result it should not have contained: warning
]Result validation: ✅ Known issue matched with the provided build.
Validation performed at: 1/16/2025 6:10:01 PM UTC
The text was updated successfully, but these errors were encountered: