Fix test projects which reference self-contained Exes #17594
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
dsplaisted
force-pushed
the
fix-test-selfcontained-error
branch
from
c9c9715 to
ec4f41e
Compare
|
@dsplaisted I was going to try to prep a build for insertion today, do we need to wait for this PR to do that? |
sfoslund
approved these changes
May 13, 2021
|
@sfoslund We're going to take this to tactics today, so yes hold off until after that. Thanks! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #17579
Description
In #15134, we added an error when a self-contained app references a non self-contained app, or vice versa. This is because if you are trying to get copies of both apps in the output folder, they won't both work.
However, I didn't consider that test projects are also use the
ExeOutputType. So with that change, test projects which reference Exe projects which were self-contained would fail to build.Customer Impact
Test projects referencing Exe projects (fairly common, especially for Web projects) which were self-contained (not as common, but enough that at least two projects hit this bug in the preview) would fail to build. This could be worked around by setting the
ValidateExecutableReferencesMatchSelfContainedproperty to false, but developers would have to look through our MSBuild code or search for help on the internet to figure out they needed to do that.Regression?
Regressed from 5.0.2xx and prior behavior in #15134.
Risk
[Justify the selection above]
The change is to disable the error check for unit test projects, and is a simple code change.
Verification
Added test cases covering failing scenario
Packaging changes reviewed?
Addresses [issue number]
#17579