Gate warnings for localization asset locales on TFM >= 7 #28060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
baronfel
changed the title
dsplaisted
approved these changes
Sep 21, 2022
src/Tasks/Microsoft.NET.Build.Tasks.UnitTests/GivenAResolvePackageAssetsTask.cs
Outdated
Show resolved
Hide resolved
|
Approved via email |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In #26729 we introduced a new warning to .NET 7 SDKs around inconsistent locale casing for resources found in NuGet packages, but we did not gate that warning on a TFM change. This means that users that work on case-insensitive file systems are very likely to start hitting the new warning on an SDK update, instead of a TFM update. We want to not do that so that we encourage folks to update SDKs as soon as they come out. We have had reports of a couple of internal customers
Regression
No, instead we want to change the default. I suppose you could call it a user-experience regression?
Risk
Low, this uses existing patterns to check an already-available piece of data.
Testing