[release/7.0.1xx] Add missing EnableRuleAttributesMustMatch task property #28338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ViktorHofer
changed the title
ViktorHofer
changed the title
smasher164
approved these changes
Oct 6, 2022
|
Approved offline by Tactics |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #28336 & #28344
Customer Impact
Customers who use APICompat's PackageValidation feature can't enable the optional
AttributesMustMatchrule (in the msbuild frontend) that validates that attributes are compatible between the contract and the implementation. The property/parameter is already exposed in the task but the targets file never passed the msbuild propertyApiCompatEnableRuleAttributesMustMatchinto the task.Testing
I verified that the property is now passed into the
ValidatePackagetask correctly and filed #28337 for adding CI protection.Risk
Low. This is an opt-in rule and customers need to explicitly set the msbuild property to true.