make error for workload info clean Fixes #42581 #42630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Workloads
untriaged
joeloff
reviewed
Aug 12, 2024
| @@ -51,9 +45,16 @@ internal static string GetWorkloadsVersion(WorkloadInfoHelper workloadInfoHelper | |||
| internal static void ShowWorkloadsInfo(ParseResult parseResult = null, WorkloadInfoHelper workloadInfoHelper = null, IReporter reporter = null, string dotnetDir = null, bool showVersion = true) | |||
| { | |||
| workloadInfoHelper ??= new WorkloadInfoHelper(parseResult != null ? parseResult.HasOption(SharedOptions.InteractiveOption) : false); | |||
| reporter ??= Utils.Reporter.Output; | |||
| var globalJsonInformation = workloadInfoHelper.ManifestProvider.GetGlobalJsonInformation(); | |||
| if (globalJsonInformation?.WorkloadVersionInstalled == false) | |||
There was a problem hiding this comment.
probably don't need the == false,
There was a problem hiding this comment.
globalJsonInformation could be null, and if not, WorkloadVersionInstalled could be true or false, so this is really a bool?, hence the == false.
marcpopMSFT
approved these changes
Aug 13, 2024
|
/backport to release/9.0.1xx |
|
Started backporting to release/9.0.1xx: https://github.com/dotnet/sdk/actions/runs/10950545869 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #42581
dotnet workload list has a special check to ensure that if a global.json file exists that specifies a particular workload set, then that workload set is installed. If not, it informs the user that they should do that first.
dotnet workload --info did not. The result was that it would give an ugly error with a stack trace.
This gives it the clean error message.
The bug didn't mention this, but I believe dotnet --info is also broken in the same case. This resolves that as well.